Skip to content

Conversation

rgee0
Copy link
Contributor

@rgee0 rgee0 commented Sep 11, 2025

Description

Enables the arm64 variants of Dive now that the binaries are available
Also pins grafana-agent at v0.44.2 as v0.44.3 is missing the assets which fails the e2e tests

Motivation and Context

  • I have raised an issue to propose this change, which has been given a label of design/approved by a maintainer (required)

How Has This Been Tested?

Functional

➜  arkade git:(armDive) ✗ make build              
go build
➜  arkade git:(armDive) ✗ ./arkade get dive       
Downloading: dive
2025/09/11 20:11:35 Looking up version for: dive
2025/09/11 20:11:35 Found: v0.13.1
Downloading: https://github.com/wagoodman/dive/releases/download/v0.13.1/dive_0.13.1_darwin_arm64.tar.gz
3.68 MiB / 3.68 MiB [----------------------------------------------------------------------------------------------] 100.00%
/var/folders/22/3b_f27kj3s37lbfqz_fq44jw0000gp/T/arkade-3337126110/dive_0.13.1_darwin_arm64.tar.gz written.
2025/09/11 20:11:35 Extracted: /var/folders/22/3b_f27kj3s37lbfqz_fq44jw0000gp/T/arkade-3337126110/dive
2025/09/11 20:11:35 Copying /var/folders/22/3b_f27kj3s37lbfqz_fq44jw0000gp/T/arkade-3337126110/dive to /Users/rgee0/.arkade/bin/dive

Wrote: /Users/rgee0/.arkade/bin/dive (9.565MB)

# Add arkade binary directory to your PATH variable
export PATH=$PATH:$HOME/.arkade/bin/

# Test the binary:
/Users/rgee0/.arkade/bin/dive

# Or install with:
sudo mv /Users/rgee0/.arkade/bin/dive /usr/local/bin/

👏 Say thanks for arkade and sponsor Alex via GitHub: https://github.com/sponsors/alexellis

test_tool.sh

➜  arkade git:(armDive) ✗ ./hack/test-tool.sh dive
+ ./arkade get dive --arch arm64 --os darwin --quiet
+ file /Users/rgee0/.arkade/bin/dive
/Users/rgee0/.arkade/bin/dive: Mach-O 64-bit executable arm64
+ rm /Users/rgee0/.arkade/bin/dive
+ echo

+ ./arkade get dive --arch x86_64 --os darwin --quiet
+ file /Users/rgee0/.arkade/bin/dive
/Users/rgee0/.arkade/bin/dive: Mach-O 64-bit executable x86_64
+ rm /Users/rgee0/.arkade/bin/dive
+ echo

+ ./arkade get dive --arch x86_64 --os linux --quiet
+ file /Users/rgee0/.arkade/bin/dive
/Users/rgee0/.arkade/bin/dive: ELF 64-bit LSB executable, x86-64, version 1 (SYSV), statically linked, BuildID[sha1]=5df2baec0291784a0bf8c6ce0d514fb530932862, stripped
+ rm /Users/rgee0/.arkade/bin/dive
+ echo

+ ./arkade get dive --arch aarch64 --os linux --quiet
+ file /Users/rgee0/.arkade/bin/dive
/Users/rgee0/.arkade/bin/dive: ELF 64-bit LSB executable, ARM aarch64, version 1 (SYSV), statically linked, BuildID[sha1]=b4f6c611216a26a49f2ba730fb1dcc81fd8a7508, stripped
+ rm /Users/rgee0/.arkade/bin/dive
+ echo

+ ./arkade get dive --arch x86_64 --os mingw --quiet
+ file /Users/rgee0/.arkade/bin/dive.exe
/Users/rgee0/.arkade/bin/dive.exe: PE32+ executable (console) x86-64, for MS Windows
+ rm /Users/rgee0/.arkade/bin/dive.exe
+ echo

make e2e (unrelated failure)

➜  arkade git:(armDive) ✗ make e2e 
CGO_ENABLED=0 go test github.com/alexellis/arkade/pkg/get -cover --tags e2e -v
...
--- PASS: Test_DownloadDive (0.00s)
...
PASS
coverage: 62.3% of statements
ok      github.com/alexellis/arkade/pkg/get     8.426s  coverage: 62.3% of statements

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Documentation

  • I have updated the list of tools in README.md if (required) with ./arkade get --format markdown
  • I have updated the list of apps in README.md if (required) with ./arkade install --help

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have tested this on arm, or have added code to prevent deployment

@alexellis alexellis merged commit c70d903 into alexellis:master Sep 11, 2025
2 checks passed
@alexellis
Copy link
Owner

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants