feat(cable) keep data input order

[xosxos]

Hey, I had issues with the git log order getting shuffled in tv git-log.

If you want to add another dependency, IndexSet from indexmap, would do the same thing as the HashSet AND preserve order with roughly the same performance rustc PR45282. Also, indexmap is already included in the dependency tree, so this shouldn't really affect compile times either. Cheers

[xosxos]

I think this also at least mostly closes #194

[alexpasmantier]

Very nice, that's helpful, thanks 🙏🏻

A couple of tests and linting errors to fix (rebasing on main should do it for the linting issues) and let's merge this.

[xosxos]

Sounds good, and oh yes sorry, I didn't run the tests 😅

[xosxos]

Also, I assume that this use of HashSet is for deduplification, which is a bit problematic as It's potentially a noticeable performance hit to re-allocate there, and at the same time it's unnecessary for many applications such as logs etc. I guess the first thing would be to change the hash algorithm to a faster one and then down the line if it bottlenecks do something a bit more sophisticated.

[alexpasmantier]

You're absolutely right.

https://crates.io/crates/rustc-hash should be more than enough here and we might see a noticeable performance improvement.

I do agree deduplicating here does not suit all purposes, but I felt it was nice to have in most cases. If it becomes more of a problematic issue, doing something more sophisticated down the line like you mentioned might be the way to go indeed.

[alexpasmantier]

Fyi #237

Thanks for the suggestion 🙏🏻

[alexpasmantier]

Ended up dropping the deduplication process altogether in #248 since it solves an issue and is always good for performance.

Closing this, thanks 🙏🏻