Try to skip extended header in MetaBox. #111
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This conflicts with #95. I can probably change the logic in my PR a bit so they are compatible. |
w-flo
force-pushed
the
skip_extended_meta_header
branch
from
eb27e46 to
55ee392
Compare
|
Pushed a new commit that should have better compatibility with the other PR Edit: I suspect the "UdtaBox" in the return Err() path in the current release is a typo and me changing it to "MetaBox" is correct? |
alfg
approved these changes
Jul 29, 2023
alfg
approved these changes
Jul 29, 2023
pando-fredrik
pushed a commit
to pando-fredrik/mp4-rust
that referenced
this pull request
May 13, 2024
Fixes alfg#102 Co-authored-by: Alfred Gutierrez <[email protected]>
pando-fredrik
pushed a commit
to pando-fredrik/mp4-rust
that referenced
this pull request
May 13, 2024
Fixes alfg#102 Co-authored-by: Alfred Gutierrez <[email protected]>
pando-fredrik
added a commit
to pando-fredrik/mp4-rust
that referenced
this pull request
May 13, 2024
* Add support for multiple trex boxes. While it's common to construct a fMP4 file for a single track, it's totally valid to have multiple tracks. This means you also need multiple to support multiple trex boxes. Untested. * cargo fmt * Add a missing write_box call for mvex. * Ran clippy * Fix more errors when serializing a mvex box. udta is also broken but that can be fixed in another PR. * Derive Default trait for DataType (alfg#100) * fix clippy (rustc 1.71.0) (alfg#115) * Allow Hdlr to be not the first in the Meta box (alfg#95) While the spec says that the hdlr box should be the first one, not all implementations follow that. Actually look over all boxes in Meta to find Hdlr. Also add a test for such weirdly-formatted box Change the way unknown MetaBox is stored: store a list of boxes instead of raw bytes Co-authored-by: Alfred Gutierrez <[email protected]> * Try to skip extended header in MetaBox. (alfg#111) Fixes alfg#102 Co-authored-by: Alfred Gutierrez <[email protected]> * Release 0.14.0 (alfg#117) * Update Cargo.toml * Update README.md * Fix getting samples from movie fragments (alfg#106) * Fix getting samples from movie fragments * Add a function to the reader to read in fragments from a different reader --------- Co-authored-by: Alfred Gutierrez <[email protected]> * Export all boxes to allow more flexible use for writing (alfg#108) Co-authored-by: Alfred Gutierrez <[email protected]> * Fix some minor issues writing traf box (alfg#109) Co-authored-by: Alfred Gutierrez <[email protected]> * Fix writing SLConfigDescriptor (alfg#107) Co-authored-by: Alfred Gutierrez <[email protected]> * Extract esds box from wave box (alfg#96) * Extract esds from wave box * Allow empty, multi-byte, and arbitrary NUL terminated strings * Skip unsupported avc1 sub-boxes * Fixed non-integer framerates * Fixed bitrate calculation * Fixed format issue * Public read sample offset * Fix lint warning. --------- Co-authored-by: Alfred Gutierrez <[email protected]> * hev1 box parser (alfg#101) Co-authored-by: Alfred Gutierrez <[email protected]> --------- Co-authored-by: Luke Curley <[email protected]> Co-authored-by: Linus Unnebäck <[email protected]> Co-authored-by: rolleifx <[email protected]> Co-authored-by: ⭐️NINIKA⭐️ <[email protected]> Co-authored-by: Alfred Gutierrez <[email protected]> Co-authored-by: w-flo <[email protected]> Co-authored-by: jensenn <[email protected]> Co-authored-by: emkman99 <[email protected]> Co-authored-by: Andrey Tkachenko <[email protected]>
jprochazk
pushed a commit
to jprochazk/mp4
that referenced
this pull request
Sep 18, 2024
Fixes alfg#102 Co-authored-by: Alfred Gutierrez <[email protected]>
CandleCandle
pushed a commit
to CandleCandle/mp4-rust
that referenced
this pull request
May 7, 2025
Fixes alfg#102 Co-authored-by: Alfred Gutierrez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #102
I've made sure
cargo teststill works, but I haven't looked into the tests to see if they actually cover this piece of code. So if they don't, more testing is needed.Other than that, I've tested this with my mp4 files that were affected by #102 and it fixes the issue for me.