Migrate to React 16 #431
Migrate to React 16 #431
Conversation
|
Deploy preview ready! Built with commit aae7c11 |
|
Deploy preview ready! Built with commit 5911b20 |
mthuret
force-pushed
the
migrate/react-16
branch
from
9627e5a to
f89a32f
Compare
| @@ -2,18 +2,19 @@ | |||
| "private": true, | |||
| "devDependencies": { | |||
| "identity-obj-proxy": "3.0.0", | |||
| "jest-environment-jsdom-11.0.0": "^20.0.9", | |||
There was a problem hiding this comment.
this is now an external package is that it?
There was a problem hiding this comment.
There was a problem hiding this comment.
Sorry the documentation of jest says the default is jsdom, am I missing something?
Ok so reference is jestjs/jest#3655 and https://github.com/Micromeritics/jest-environment-jsdom-11.0.0
Let's watch those to be able to remove this code afterwards
| @@ -23,7 +24,9 @@ | |||
| "notify": false, | |||
| "moduleNameMapper": { | |||
| "\\.(css)$": "identity-obj-proxy" | |||
| } | |||
| }, | |||
| "setupFiles": ["../../../../shim.js"], | |||
There was a problem hiding this comment.
Maybe you can use <ROOT_DIR> smg here?
There was a problem hiding this comment.
Could be better indeed :)
There was a problem hiding this comment.
@vvo is here referring to the directory where the example package.json is, and therefore, can't work if shim.js is only at the very root of the project?
There was a problem hiding this comment.
Indeed root_dir would be the example/package.json.
Also this seems temporary given comments in facebook/create-react-app#3199, just watch the issue and remove it afterwards
| @@ -0,0 +1,4 @@ | |||
| // see: https://github.com/facebookincubator/create-react-app/issues/3199 | |||
There was a problem hiding this comment.
It's already fixed in Jest, just not released yet; see jestjs/jest#4545 (comment)
|
That's some serious chore/build stuff, much needed to ensure we are always up with the latest versions! GG |
|
LGTM |
Just to test with CI
Remaining known issues:
recipes test passes but there seems to have a "timeout" issue that make the script failed. For instance, when removing the content of the autocomplete tests,
npm run test:recipespass.storybook is failing like crazy. See: Error when clicking on the menu item on React 16 storybookjs/storybook#1965 (workaround found by deactivating animations on the sidebar).
warning in test about Error Boundaries. See: Allow suppressing error boundary logs from intentionally thrown/caught errors facebook/react#11098 (not mandatory)