Skip to content

Conversation

@jannotti
Copy link
Contributor

@jannotti jannotti commented Dec 4, 2024

The PR to put heartbeats into main. The new heartbeats/README.md is the best place to look for explaining it.

@jannotti jannotti changed the title Feature/heartbeats Eval: Feature/heartbeats Dec 4, 2024
@jannotti jannotti self-assigned this Dec 4, 2024
@codecov
Copy link

codecov bot commented Dec 5, 2024

Codecov Report

Attention: Patch coverage is 68.10345% with 148 lines in your changes missing coverage. Please review.

Project coverage is 52.00%. Comparing base (b7b3e5e) to head (9a5386d).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
daemon/algod/api/client/restClient.go 0.00% 28 Missing ⚠️
ledger/eval/eval.go 73.73% 17 Missing and 9 partials ⚠️
crypto/onetimesig.go 0.00% 20 Missing ⚠️
libgoal/libgoal.go 0.00% 16 Missing ⚠️
heartbeat/service.go 85.33% 6 Missing and 5 partials ⚠️
cmd/loadgenerator/main.go 0.00% 6 Missing ⚠️
ledger/apply/heartbeat.go 82.85% 3 Missing and 3 partials ⚠️
data/transactions/logic/assembler.go 0.00% 5 Missing ⚠️
ledger/ledgercore/accountdata.go 0.00% 5 Missing ⚠️
data/transactions/transaction.go 85.71% 4 Missing ⚠️
... and 9 more
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6189      +/-   ##
==========================================
+ Coverage   51.88%   52.00%   +0.11%     
==========================================
  Files         639      642       +3     
  Lines       85489    85834     +345     
==========================================
+ Hits        44359    44635     +276     
- Misses      38320    38362      +42     
- Partials     2810     2837      +27     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@jannotti jannotti marked this pull request as ready for review December 11, 2024 19:39
And include tests that !IncentiveEligible accounts won't be suspended,
despite lack of heartbeat.
@jannotti jannotti dismissed stale reviews from zeldovich and yossigi via 242f3f5 December 19, 2024 17:13
gmalouf
gmalouf previously approved these changes Dec 19, 2024
cce
cce previously approved these changes Dec 19, 2024
@jannotti jannotti merged commit fcad0bb into master Dec 19, 2024
19 of 21 checks passed
@gmalouf gmalouf deleted the feature/heartbeats branch December 19, 2024 21:02
@cce cce restored the feature/heartbeats branch December 20, 2024 04:35
@gmalouf gmalouf deleted the feature/heartbeats branch August 28, 2025 14:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants