Skip to content

Conversation

@gmalouf
Copy link
Contributor

@gmalouf gmalouf commented Dec 19, 2024

Summary

Consensus version v40, major release version 4!

Test Plan

Existing tests should pass.

@codecov
Copy link

codecov bot commented Dec 20, 2024

Codecov Report

Attention: Patch coverage is 57.44681% with 20 lines in your changes missing coverage. Please review.

Project coverage is 52.10%. Comparing base (a10b6b3) to head (c4e1cca).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
ledger/store/trackerdb/sqlitedriver/kvsIter.go 0.00% 10 Missing ⚠️
...edger/store/trackerdb/sqlitedriver/sqlitedriver.go 0.00% 4 Missing ⚠️
ledger/catchupaccessor.go 33.33% 2 Missing ⚠️
ledger/store/trackerdb/dualdriver/dualdriver.go 0.00% 2 Missing ⚠️
ledger/store/trackerdb/generickv/reader.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6207      +/-   ##
==========================================
+ Coverage   50.93%   52.10%   +1.16%     
==========================================
  Files         643      649       +6     
  Lines       86223    86311      +88     
==========================================
+ Hits        43915    44969    +1054     
+ Misses      39433    38488     -945     
+ Partials     2875     2854      -21     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@onetechnical onetechnical left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The consensus and version changes look correct, and tests have passed.

@gmalouf gmalouf merged commit a1137a2 into master Dec 20, 2024
50 checks passed
@gmalouf gmalouf deleted the v40-consensus-version branch December 20, 2024 15:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants