Skip to content

Conversation

@gmalouf
Copy link
Contributor

@gmalouf gmalouf commented May 21, 2025

Summary

Update 'value' in API Box type to be optional (reflecting updated getApplicationBoxes semantics).

Test Plan

Existing tests should pass.

@gmalouf gmalouf requested a review from jannotti May 21, 2025 13:23
@gmalouf gmalouf self-assigned this May 21, 2025
jannotti
jannotti previously approved these changes May 21, 2025
@codecov
Copy link

codecov bot commented May 21, 2025

Codecov Report

Attention: Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.

Project coverage is 51.83%. Comparing base (64ae8b0) to head (2062b56).
Report is 1 commits behind head on master.

Files with missing lines Patch % Lines
daemon/algod/api/server/v2/handlers.go 0.00% 3 Missing ⚠️
cmd/goal/box.go 0.00% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master    #6333      +/-   ##
==========================================
- Coverage   51.86%   51.83%   -0.03%     
==========================================
  Files         653      653              
  Lines       87547    87548       +1     
==========================================
- Hits        45408    45384      -24     
- Misses      39264    39290      +26     
+ Partials     2875     2874       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@gmalouf gmalouf merged commit 84b6567 into algorand:master May 21, 2025
19 checks passed
@gmalouf gmalouf deleted the boxes-response-tweak branch May 21, 2025 17:11
gmalouf added a commit to gmalouf/go-algorand that referenced this pull request May 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants