network: fix double counting in numOutgoingPending #6517
Merged
+67
−1
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tryConnectAddrs always populates two entries per pending connection: addr and gossipAddr that leads to 2x of pending conns reported by numOutgoingPending wo that meshThreadInner always reports inflated value
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6517 +/- ##
==========================================
- Coverage 47.87% 47.69% -0.19%
==========================================
Files 662 655 -7
Lines 87934 87849 -85
==========================================
- Hits 42095 41896 -199
- Misses 43076 43179 +103
- Partials 2763 2774 +11 ☔ View full report in Codecov by Sentry. |
jannotti
approved these changes
Dec 17, 2025
gmalouf
reviewed
Dec 17, 2025
gmalouf
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
tryConnectAddrsalways populates two entries per pending connection:addrandgossipAddrthat leads to 2x of pending conns reported bynumOutgoingPending()so thatmeshThreadInneralways reports inflated valueTest Plan
Added a test checking even numbers in the map and a proper number of pending conns returned.