Skip to content

fix: an inaccurate error message when parsing a log level from a string#3221

Merged
LearningGp merged 1 commit into
alibaba:masterfrom
SkipperQ:master
Sep 19, 2024
Merged

fix: an inaccurate error message when parsing a log level from a string#3221
LearningGp merged 1 commit into
alibaba:masterfrom
SkipperQ:master

Conversation

@SkipperQ
Copy link
Copy Markdown

@SkipperQ SkipperQ commented Sep 2, 2023

Describe what this PR does / why we need it

Fix a bug where an inaccurate error message is displayed when parsing a log level from a string due to the incorrect use of the logLevel variable instead of logLevelString in the error message.

Does this pull request fix one issue?

Fixes #3192

Describe how you did it

Replace logLevel with logLevelString.

@CLAassistant
Copy link
Copy Markdown

CLAassistant commented Sep 2, 2023

CLA assistant check
All committers have signed the CLA.

@SkipperQ
Copy link
Copy Markdown
Author

SkipperQ commented Sep 3, 2023

@sczyh30

Copy link
Copy Markdown
Collaborator

@LearningGp LearningGp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@LearningGp LearningGp added the area/logging Issues or PRs related to logging of Sentinel label Jan 12, 2024
@LearningGp LearningGp merged commit 2f4a044 into alibaba:master Sep 19, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

area/logging Issues or PRs related to logging of Sentinel

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[BUG] com.alibaba.csp.sentinel.log.LogBase#loadProperties() 日志输出bug

3 participants