Skip to content

Conversation

@waTErMo0n
Copy link
Contributor

Ⅰ. Describe what this PR did

Getting MatchLabels dynamically via gatewaySelectorKey/Value

Ⅱ. Does this pull request fix one issue?

feat #1857

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

1.我是一个新手,不太确定代码否正确,感谢这次机会
2.作为一个新手,让我准备好higress开发环境所需要的文档太过分散且难以寻找,希望针对开发环境的准备能有更完备的文档和点击入口

@CLAassistant
Copy link

CLAassistant commented Mar 12, 2025

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2025

Codecov Report

Attention: Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 43.68%. Comparing base (ef31e09) to head (8228392).
Report is 454 commits behind head on main.

Files with missing lines Patch % Lines
pkg/ingress/config/ingress_config.go 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1883      +/-   ##
==========================================
+ Coverage   35.91%   43.68%   +7.77%     
==========================================
  Files          69       79      +10     
  Lines       11576    12753    +1177     
==========================================
+ Hits         4157     5571    +1414     
+ Misses       7104     6835     -269     
- Partials      315      347      +32     
Files with missing lines Coverage Δ
pkg/ingress/config/ingress_config.go 13.25% <50.00%> (-0.62%) ⬇️

... and 74 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@CH3CHO
Copy link
Collaborator

CH3CHO commented Mar 18, 2025

LGTM. But please fix the conflict.

@waTErMo0n
Copy link
Contributor Author

LGTM. But please fix the conflict.

done

@CH3CHO
Copy link
Collaborator

CH3CHO commented Mar 18, 2025

Since this is related to the core function of the controller, @johnlanni PTAL

@CH3CHO
Copy link
Collaborator

CH3CHO commented Mar 20, 2025

没有冲突的话也可以不用一直merge上来。等到approve了可以合并的时候再merge也行。

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@waTErMo0n
Copy link
Contributor Author

thanks

@CH3CHO CH3CHO merged commit e7d2005 into alibaba:main Apr 18, 2025
8 checks passed
ink-hz pushed a commit to ink-hz/higress-ai-capability-auth that referenced this pull request Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants