-
Notifications
You must be signed in to change notification settings - Fork 902
feat:Getting MatchLabels dynamically via gatewaySelectorKey/Value #1857 #1883
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #1883 +/- ##
==========================================
+ Coverage 35.91% 43.68% +7.77%
==========================================
Files 69 79 +10
Lines 11576 12753 +1177
==========================================
+ Hits 4157 5571 +1414
+ Misses 7104 6835 -269
- Partials 315 347 +32
🚀 New features to boost your workflow:
|
|
LGTM. But please fix the conflict. |
done |
|
Since this is related to the core function of the controller, @johnlanni PTAL |
|
没有冲突的话也可以不用一直merge上来。等到approve了可以合并的时候再merge也行。 |
johnlanni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
|
thanks |
Ⅰ. Describe what this PR did
Getting MatchLabels dynamically via gatewaySelectorKey/Value
Ⅱ. Does this pull request fix one issue?
feat #1857
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews
1.我是一个新手,不太确定代码否正确,感谢这次机会
2.作为一个新手,让我准备好higress开发环境所需要的文档太过分散且难以寻找,希望针对开发环境的准备能有更完备的文档和点击入口