Skip to content

Conversation

@CH3CHO
Copy link
Collaborator

@CH3CHO CH3CHO commented Mar 22, 2025

Ⅰ. Describe what this PR did

Support extracting model argument from body in multipart/form-data format.

image

Ⅱ. Does this pull request fix one issue?

fixes #1887

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@CH3CHO CH3CHO requested review from johnlanni and rinfx as code owners March 22, 2025 02:56
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 43.73%. Comparing base (ef31e09) to head (7eb970a).
Report is 393 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #1940      +/-   ##
==========================================
+ Coverage   35.91%   43.73%   +7.82%     
==========================================
  Files          69       79      +10     
  Lines       11576    12728    +1152     
==========================================
+ Hits         4157     5567    +1410     
+ Misses       7104     6815     -289     
- Partials      315      346      +31     

see 75 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

auto content_type_ptr =
getRequestHeader(Wasm::Common::Http::Header::ContentType);
if (!absl::StrContains(content_type_value->view(),
auto content_type_value = content_type_ptr->view();
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to add unit tests

@CH3CHO CH3CHO force-pushed the feat/model-router-multipart branch from f22614d to 7eb970a Compare March 28, 2025 10:14
Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks!

@johnlanni johnlanni merged commit 1c37c36 into alibaba:main Apr 22, 2025
12 checks passed
@CH3CHO CH3CHO deleted the feat/model-router-multipart branch April 22, 2025 06:59
VinceCui pushed a commit to VinceCui/higress that referenced this pull request May 21, 2025
ink-hz pushed a commit to ink-hz/higress-ai-capability-auth that referenced this pull request Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

model_router 插件支持解析 multipart/form-data 请求体中的 model 参数

3 participants