-
Notifications
You must be signed in to change notification settings - Fork 902
feat : support mcp server auto discovery for nacos registry #2122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit a6fd8d3.
This reverts commit 237ee8d. modified: plugins/wasm-go/extensions/ai-intent/go.mod modified: plugins/wasm-go/extensions/ai-intent/go.sum modified: plugins/wasm-go/extensions/key-auth/go.mod modified: plugins/wasm-go/extensions/key-auth/go.sum modified: plugins/wasm-go/extensions/oidc/go.mod modified: plugins/wasm-go/mcp-servers/all-in-one/go.mod
modified: registry/nacos/mcpserver/watcher.go
This reverts commit 89992f0. modified: plugins/wasm-go/extensions/ai-intent/go.mod modified: plugins/wasm-go/extensions/ai-intent/go.sum modified: plugins/wasm-go/extensions/key-auth/go.mod modified: plugins/wasm-go/extensions/key-auth/go.sum modified: plugins/wasm-go/extensions/oidc/go.mod
modified: plugins/wasm-go/extensions/key-auth/go.mod modified: plugins/wasm-go/extensions/key-auth/go.sum modified: plugins/wasm-go/extensions/oidc/go.mod modified: plugins/wasm-go/mcp-servers/all-in-one/go.mod modified: registry/nacos/mcpserver/watcher.go
Codecov ReportAttention: Patch coverage is
❌ Your patch status has failed because the patch coverage (6.74%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage. Additional details and impacted files@@ Coverage Diff @@
## main #2122 +/- ##
==========================================
+ Coverage 35.91% 45.71% +9.80%
==========================================
Files 69 79 +10
Lines 11576 12895 +1319
==========================================
+ Hits 4157 5895 +1738
+ Misses 7104 6652 -452
- Partials 315 348 +33
🚀 New features to boost your workflow:
|
modified: istio/istio
# Conflicts: # envoy/envoy
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In addition: updates to the submodule commit of envoy do not need to be submitted.
johnlanni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
johnlanni
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
…2122) Co-authored-by: 澄潭 <[email protected]>
…2122) Co-authored-by: 澄潭 <[email protected]>
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews