Skip to content

Conversation

@Erica177
Copy link
Collaborator

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

This reverts commit a6fd8d3.
This reverts commit 237ee8d.

	modified:   plugins/wasm-go/extensions/ai-intent/go.mod
	modified:   plugins/wasm-go/extensions/ai-intent/go.sum
	modified:   plugins/wasm-go/extensions/key-auth/go.mod
	modified:   plugins/wasm-go/extensions/key-auth/go.sum
	modified:   plugins/wasm-go/extensions/oidc/go.mod
	modified:   plugins/wasm-go/mcp-servers/all-in-one/go.mod
@Erica177 Erica177 changed the title Feature sup mcp Feature : support mcp server auto discovery for nacos registry Apr 24, 2025
	modified:   registry/nacos/mcpserver/watcher.go
@Erica177 Erica177 requested a review from rinfx as a code owner April 25, 2025 02:11
This reverts commit 89992f0.

	modified:   plugins/wasm-go/extensions/ai-intent/go.mod
	modified:   plugins/wasm-go/extensions/ai-intent/go.sum
	modified:   plugins/wasm-go/extensions/key-auth/go.mod
	modified:   plugins/wasm-go/extensions/key-auth/go.sum
	modified:   plugins/wasm-go/extensions/oidc/go.mod
	modified:   plugins/wasm-go/extensions/key-auth/go.mod
	modified:   plugins/wasm-go/extensions/key-auth/go.sum
	modified:   plugins/wasm-go/extensions/oidc/go.mod
	modified:   plugins/wasm-go/mcp-servers/all-in-one/go.mod
	modified:   registry/nacos/mcpserver/watcher.go
@codecov-commenter
Copy link

codecov-commenter commented Apr 25, 2025

Codecov Report

Attention: Patch coverage is 6.74157% with 83 lines in your changes missing coverage. Please review.

Project coverage is 45.71%. Comparing base (ef31e09) to head (39ba6a6).
Report is 478 commits behind head on main.

Files with missing lines Patch % Lines
pkg/ingress/config/ingress_config.go 0.00% 58 Missing ⚠️
pkg/ingress/kube/configmap/mcp_server.go 25.00% 17 Missing and 1 partial ⚠️
pkg/ingress/kube/configmap/controller.go 0.00% 4 Missing ⚠️
pkg/ingress/kube/configmap/global.go 0.00% 1 Missing ⚠️
pkg/ingress/kube/configmap/gzip.go 0.00% 1 Missing ⚠️
pkg/ingress/kube/configmap/tracing.go 0.00% 1 Missing ⚠️

❌ Your patch status has failed because the patch coverage (6.74%) is below the target coverage (50.00%). You can increase the patch coverage or adjust the target coverage.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2122      +/-   ##
==========================================
+ Coverage   35.91%   45.71%   +9.80%     
==========================================
  Files          69       79      +10     
  Lines       11576    12895    +1319     
==========================================
+ Hits         4157     5895    +1738     
+ Misses       7104     6652     -452     
- Partials      315      348      +33     
Files with missing lines Coverage Δ
pkg/ingress/kube/configmap/global.go 27.29% <0.00%> (-0.07%) ⬇️
pkg/ingress/kube/configmap/gzip.go 45.08% <0.00%> (-0.21%) ⬇️
pkg/ingress/kube/configmap/tracing.go 2.16% <0.00%> (-0.36%) ⬇️
pkg/ingress/kube/configmap/controller.go 0.00% <0.00%> (ø)
pkg/ingress/kube/configmap/mcp_server.go 87.60% <25.00%> (ø)
pkg/ingress/config/ingress_config.go 12.72% <0.00%> (-1.16%) ⬇️

... and 71 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Erica177 Erica177 changed the title Feature : support mcp server auto discovery for nacos registry feat : support mcp server auto discovery for nacos registry Apr 25, 2025
	modified:   istio/istio
@Erica177 Erica177 requested a review from gengleilei as a code owner April 25, 2025 07:16
Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In addition: updates to the submodule commit of envoy do not need to be submitted.

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit 5bd20aa into alibaba:main Apr 28, 2025
4 checks passed
VinceCui pushed a commit to VinceCui/higress that referenced this pull request May 21, 2025
ink-hz pushed a commit to ink-hz/higress-ai-capability-auth that referenced this pull request Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants