Skip to content

Conversation

@Tsukilc
Copy link
Contributor

@Tsukilc Tsukilc commented Apr 24, 2025

Ⅰ. Describe what this PR did

add test for /pkg/ingress/kube/common
to %66.1

Ⅱ. Does this pull request fix one issue?

fixes #89

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

image
go test -cover ./pkg/ingress/kube/common

Ⅴ. Special notes for reviews

@CLAassistant
Copy link

CLAassistant commented Apr 24, 2025

CLA assistant check
All committers have signed the CLA.

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit c241ccf into alibaba:main Apr 24, 2025
1 check passed
VinceCui pushed a commit to VinceCui/higress that referenced this pull request May 21, 2025
ink-hz pushed a commit to ink-hz/higress-ai-capability-auth that referenced this pull request Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

pkg/ingress/kube/common 单测覆盖率提高 (Increase unit test coverage)

3 participants