Skip to content

Conversation

@Jing-ze
Copy link
Collaborator

@Jing-ze Jing-ze commented Apr 29, 2025

Ⅰ. Describe what this PR did

make mcp server redis client config based

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@Jing-ze Jing-ze marked this pull request as ready for review April 29, 2025 05:56
@Jing-ze Jing-ze requested a review from johnlanni as a code owner April 29, 2025 05:56
@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.


daijingze_mac seems not to be a GitHub user. You need a GitHub account to be able to sign the CLA. If you have already a GitHub account, please add the email address used for this commit to your account.
You have signed the CLA already but the status is still pending? Let us recheck it.

@Jing-ze Jing-ze requested review from CH3CHO and rinfx as code owners April 29, 2025 05:56
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.71%. Comparing base (ef31e09) to head (6fcdb54).
Report is 482 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2145      +/-   ##
==========================================
+ Coverage   35.91%   45.71%   +9.80%     
==========================================
  Files          69       79      +10     
  Lines       11576    12895    +1319     
==========================================
+ Hits         4157     5895    +1738     
+ Misses       7104     6652     -452     
- Partials      315      348      +33     

see 77 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit ab73f21 into alibaba:main Apr 29, 2025
11 of 12 checks passed
VinceCui pushed a commit to VinceCui/higress that referenced this pull request May 21, 2025
ink-hz pushed a commit to ink-hz/higress-ai-capability-auth that referenced this pull request Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants