Skip to content

Conversation

@cr7258
Copy link
Collaborator

@cr7258 cr7258 commented May 17, 2025

Ⅰ. Describe what this PR did

Allow skipping the higress-controller dev image build during wasmplugin E2E tests, because if a user only wants to test the wasmplugin, it is unnecessary to build the higress-controller dev image from scratch.

Ⅱ. Does this pull request fix one issue?

fixes #2238

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@cr7258 cr7258 requested a review from johnlanni May 17, 2025 16:04
@cr7258 cr7258 changed the title feat: allow skipping higress-controller dev image build during wasmplugin e2e tests feat: allow skipping higress dev image build during wasmplugin e2e tests May 17, 2025
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.81%. Comparing base (ef31e09) to head (506fd2e).
Report is 509 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #2264      +/-   ##
==========================================
+ Coverage   35.91%   45.81%   +9.89%     
==========================================
  Files          69       79      +10     
  Lines       11576    12912    +1336     
==========================================
+ Hits         4157     5915    +1758     
+ Misses       7104     6650     -454     
- Partials      315      347      +32     

see 77 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copy link
Collaborator

@johnlanni johnlanni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johnlanni johnlanni merged commit ec83623 into alibaba:main May 26, 2025
15 checks passed
ink-hz pushed a commit to ink-hz/higress-ai-capability-auth that referenced this pull request Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

E2E test for ext-auth WasmPlugin fails due to Docker build issues with Alibaba Cloud registry

3 participants