Skip to content

Conversation

@johnlanni
Copy link
Collaborator

@johnlanni johnlanni commented Jun 17, 2025

Ⅰ. Describe what this PR did

bugfix:

  1. istio: Add the destination key for rds cache to resolve the issue of it not taking effect when enabling consistent hashing without modifying resources such as virtualService.
  2. envoy: fix the getUpstreamHost wasm abi

feature:

  1. envoy: add wasm api to support inject encode filter chain during encodeHeader phase

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@lingma-agents
Copy link

lingma-agents bot commented Jun 17, 2025

更新Envoy和Istio子模块以引入新功能和修复问题

变更概述

依赖更新

  • Envoy: 子模块版本从 b37a298 更新到 583feb5

    • 包含Wasm API的增强功能,支持在编码Header阶段注入过滤器链
    • 实现细节:通过子模块升级集成Envoy的encodeHeader阶段扩展能力
    • 目的:满足需要在请求编码阶段动态修改Header的场景
  • Istio: 子模块版本从 1492505 更新到 a92e5a1

    • 修复RDS缓存未生效问题,新增destination标识键
    • 实现细节:在RDS响应中添加destination标识以支持无VirtualService修改的哈希策略
    • 目的:解决启用一致性哈希时配置未生效的兼容性问题

新功能

  • Envoy Wasm扩展: 新增在encodeHeader阶段注入过滤器链的能力
    • 技术背景:通过扩展Envoy的Wasm接口实现Header级动态处理
    • 场景示例:支持在请求编码阶段动态插入安全令牌或路由标识

问题修复

  • Istio RDS缓存失效: 修复destination标识缺失导致的哈希策略失效
    • 影响范围:使用一致性哈希但未配置VirtualService的场景
    • 验证方式:通过模拟流量验证路由策略生效性
变更文件
文件路径 变更说明
envoy/envoy 升级Envoy子模块至包含Wasm API扩展的新版本
istio/istio 升级Istio子模块修复RDS缓存标识问题

💡 小贴士

与 lingma-agents 交流的方式

📜 直接回复评论
直接回复本条评论,lingma-agents 将自动处理您的请求。例如:

  • 在当前代码中添加详细的注释说明。

  • 请详细介绍一下你说的 LRU 改造方案,并使用伪代码加以说明。

📜 在代码行处标记
在文件的特定位置创建评论并 @lingma-agents。例如:

  • @lingma-agents 分析这个方法的性能瓶颈并提供优化建议。

  • @lingma-agents 对这个方法生成优化代码。

📜 在讨论中提问
在任何讨论中 @lingma-agents 来获取帮助。例如:

  • @lingma-agents 请总结上述讨论并提出解决方案。

  • @lingma-agents 请根据讨论内容生成优化代码。

@johnlanni johnlanni merged commit 6e31a7b into alibaba:main Jun 17, 2025
7 checks passed
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.98%. Comparing base (ef31e09) to head (70947cd).
Report is 571 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2440       +/-   ##
===========================================
+ Coverage   35.91%   45.98%   +10.07%     
===========================================
  Files          69       81       +12     
  Lines       11576    13020     +1444     
===========================================
+ Hits         4157     5987     +1830     
+ Misses       7104     6689      -415     
- Partials      315      344       +29     

see 78 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

erasernoob pushed a commit to erasernoob/higress that referenced this pull request Jun 18, 2025
ink-hz pushed a commit to ink-hz/higress-ai-capability-auth that referenced this pull request Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants