Skip to content

Conversation

@johnlanni
Copy link
Collaborator

Ⅰ. Describe what this PR did

mcp server plugin support errorResponseTemplate to customize response when backend http status greater than 300:
higress-group/wasm-go#3

doc:
higress-group/higress-console#538

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

@johnlanni johnlanni requested review from CH3CHO and rinfx as code owners June 24, 2025 03:04
@lingma-agents
Copy link

lingma-agents bot commented Jun 24, 2025

🔍 代码审查进行中

⏳ 正在审查

⏰️ 剩余时间:约需数分钟

🔄 分支流向: mcp-server-support-error-template-responsemain

📦 提交: 审查当前PR从e94ac43b4a4169的提交。


📒 文件清单 (2 个文件)
📝 变更: 2 个文件

📝 变更文件:

  • plugins/wasm-go/mcp-servers/all-in-one/go.mod
  • plugins/wasm-go/mcp-servers/all-in-one/go.sum

@lingma-agents
Copy link

lingma-agents bot commented Jun 24, 2025

升级wasm-go依赖并支持错误响应模板

变更概述

依赖更新

  • components: plugins/wasm-go/mcp-servers/all-in-one/go.mod, go.sum
  • description: 将github.com/higress-group/wasm-go依赖版本从v1.0.0升级到v1.0.1-0.20250623123120-09fcd617236a
  • implementation: 更新go.mod中的require声明,并同步更新go.sum的校验信息
  • purpose: 引入wasm-go新版本中对错误响应模板的功能支持

新功能

  • components: MCP服务器插件
  • description: 增加errorResponseTemplate功能,允许自定义HTTP状态码≥300时的响应格式
  • technical context: 通过解析用户提供的模板配置,动态生成符合要求的错误响应内容
  • purpose: 提升错误信息的可定制性,增强API交互的灵活性
变更文件
文件路径 变更说明
plugins/​wasm-go/​mcp-servers/​all-in-one/​go.​mod 升级wasm-go依赖版本到指定预发布版本
plugins/​wasm-go/​mcp-servers/​all-in-one/​go.​sum 添加新依赖版本的校验哈希值

💡 小贴士

与 lingma-agents 交流的方式

📜 直接回复评论
直接回复本条评论,lingma-agents 将自动处理您的请求。例如:

  • 在当前代码中添加详细的注释说明。

  • 请详细介绍一下你说的 LRU 改造方案,并使用伪代码加以说明。

📜 在代码行处标记
在文件的特定位置创建评论并 @lingma-agents。例如:

  • @lingma-agents 分析这个方法的性能瓶颈并提供优化建议。

  • @lingma-agents 对这个方法生成优化代码。

📜 在讨论中提问
在任何讨论中 @lingma-agents 来获取帮助。例如:

  • @lingma-agents 请总结上述讨论并提出解决方案。

  • @lingma-agents 请根据讨论内容生成优化代码。

@johnlanni johnlanni merged commit f4d3fec into alibaba:main Jun 24, 2025
8 of 9 checks passed
@lingma-agents
Copy link

lingma-agents bot commented Jun 24, 2025

CodeReview流程已终止


CodeReview process has been terminated

@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 45.95%. Comparing base (ef31e09) to head (b4a4169).
Report is 583 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@             Coverage Diff             @@
##             main    #2485       +/-   ##
===========================================
+ Coverage   35.91%   45.95%   +10.04%     
===========================================
  Files          69       81       +12     
  Lines       11576    13020     +1444     
===========================================
+ Hits         4157     5983     +1826     
+ Misses       7104     6690      -414     
- Partials      315      347       +32     

see 78 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

ink-hz pushed a commit to ink-hz/higress-ai-capability-auth that referenced this pull request Nov 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants