fix: llm can be empty and optimize document and prompt #2942
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2456868764
requested review from
CH3CHO,
erasernoob,
johnlanni and
rinfx
as code owners
RAG服务优化与LLM配置灵活性增强变更概述
变更文件
💡 小贴士与 lingma-agents 交流的方式📜 直接回复评论
📜 在代码行处标记
📜 在讨论中提问
|
![lingma-agents[bot]](https://avatars.githubusercontent.com/in/1198481?s=60&v=4){kind=small}
There was a problem hiding this comment.
🔎 代码评审报告
🎯 评审意见概览
| 严重度 | 数量 | 说明 |
|---|---|---|
| 🔴 Blocker | 0 | 阻断性问题，需立即修复。例如：系统崩溃、关键功能不可用或严重安全漏洞。 |
| 🟠 Critical | 0 | 严重问题，高优先级修复。例如：核心功能异常或性能瓶颈影响用户体验。 |
| 🟡 Major | 0 | 主要问题，建议修复。例如：非核心功能缺陷或代码维护性较差。 |
| 🟢 Minor | 2 | 次要问题，酬情优化。例如：代码格式不规范或注释缺失。 |
总计: 2 个问题
📋 评审意见详情
💡 代码实现建议
以下是文件级别的代码建议，聚焦于代码的可读性、可维护性和潜在问题。
🔹 plugins/golang-filter/mcp-server/servers/rag/rag_client.go (1 💬)
- 增强LLM提供者初始化的健壮性 (L49-L56)
🔹 plugins/golang-filter/mcp-server/servers/rag/server.go (1 💬)
- 确保默认配置中LLM提供者为空 (L31)
🚀 架构设计建议
✅ 代码结构清晰，架构设计合理。未发现需要特别关注的系统级问题。
审查详情
📒 文件清单 （7 个文件）
📝 变更: 7 个文件
📝 变更文件:
plugins/golang-filter/mcp-server/servers/rag/READMD.mdplugins/golang-filter/mcp-server/servers/rag/llm/openai.goplugins/golang-filter/mcp-server/servers/rag/llm/prompt.goplugins/golang-filter/mcp-server/servers/rag/rag_client.goplugins/golang-filter/mcp-server/servers/rag/rag_client_test.goplugins/golang-filter/mcp-server/servers/rag/server.goplugins/golang-filter/mcp-server/servers/rag/tools.go
💡 小贴士
与 lingma-agents 交流的方式
📜 直接回复评论
直接回复本条评论，lingma-agents 将自动处理您的请求。例如：
-
在当前代码中添加详细的注释说明。
-
请详细介绍一下你说的 LRU 改造方案，并使用伪代码加以说明。
📜 在代码行处标记
在文件的特定位置创建评论并 @lingma-agents。例如：
-
@lingma-agents 分析这个方法的性能瓶颈并提供优化建议。
-
@lingma-agents 对这个方法生成优化代码。
📜 在讨论中提问
在任何讨论中 @lingma-agents 来获取帮助。例如：
-
@lingma-agents 请总结上述讨论并提出解决方案。
-
@lingma-agents 请根据讨论内容生成优化代码。
Comment on lines
+49
to
+56
| if ragclient.config.LLM.Provider == "" { | ||
| ragclient.llmProvider = nil | ||
| } else { | ||
| llmProvider, err := llm.NewLLMProvider(ragclient.config.LLM) | ||
| if err != nil { | ||
| return nil, fmt.Errorf("create llm provider failed, err: %w", err) | ||
| } | ||
| ragclient.llmProvider = llmProvider |
| }, | ||
| LLM: config.LLMConfig{ | ||
| Provider: "openai", | ||
| Provider: "", |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2942 +/- ##
==========================================
+ Coverage 35.91% 44.95% +9.03%
==========================================
Files 69 82 +13
Lines 11576 13377 +1801
==========================================
+ Hits 4157 6013 +1856
+ Misses 7104 7016 -88
- Partials 315 348 +33 🚀 New features to boost your workflow:
|
johnlanni
requested changes
Sep 23, 2025
| @@ -23,40 +23,36 @@ | |||
|
|
|||
| ### 配置结构 | |||
|
|
|||
| ``` | ||
|
|
||
|
|
||
|
|
Collaborator
There was a problem hiding this comment.
文档里建议说明一下：
- 有哪些mcp工具，各自的用处是什么；
- 哪些mcp工具是可选的，哪些是必须的；
- 具备最小的工具集时的典型用例，和具备最全的工具集时的典型用例；
- mcp工具跟配置之间的关系是怎样的，例如没有配置llm时就没有chat工具；
johnlanni
requested changes
Sep 23, 2025
Tsukilc
pushed a commit
to Tsukilc/higress
that referenced
this pull request
Sep 30, 2025
ink-hz
pushed a commit
to ink-hz/higress-ai-capability-auth
that referenced
this pull request
Nov 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Ⅰ. Describe what this PR did
Ⅱ. Does this pull request fix one issue?
Ⅲ. Why don't you add test cases (unit test/integration test)?
Ⅳ. Describe how to verify it
Ⅴ. Special notes for reviews