feat: add ip-restriction wasm-go plugin #759

Renz7 · 2024-01-06T22:11:17Z

Ⅰ. Describe what this PR did

ip-restriction impl.

Ⅱ. Does this pull request fix one issue?

fixes #607

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

e2e test pass

=== RUN   TestHigressConformanceTests/WasmPluginsIpRestriction
    suite.go:209: 🔥 Running Conformance Test: WasmPluginsIpRestriction
    suite.go:212: 🧳 Applying Manifests: tests/go-wasm-ip-restriction.yaml
    apply.go:149: 🏗 Creating httproute-app-root Ingress
    apply.go:149: 🏗 Creating ip-restriction WasmPlugin
=== RUN   TestHigressConformanceTests/WasmPluginsIpRestriction/WasmPlugins_ip-restriction
    go-wasm-ip-restriction.go:114: Making GET request to http://localhost/info
Sending Request:
< GET /info HTTP/1.1
< Host: foo.com
< User-Agent: Go-http-client/1.1
< X-Echo-Set-Header: 
< X-Real-Ip: 10.0.0.1
< Accept-Encoding: gzip
< 
< 

    http.go:252: Request failed, not ready yet: Get "http://localhost/info": read tcp [::1]:59799->[::1]:80: read: connection reset by peer (after 2.25µs)
Sending Request:
< GET /info HTTP/1.1
< Host: foo.com
< User-Agent: Go-http-client/1.1
< X-Echo-Set-Header: 
< X-Real-Ip: 10.0.0.1
< Accept-Encoding: gzip
< 
< 

Received Response:
< HTTP/1.1 200 OK
< Content-Length: 946
< Content-Type: application/json
< Date: Sat, 06 Jan 2024 21:39:10 GMT
< Req-Arrive-Time: 1704577150678
< Req-Cost-Time: 30
< Resp-Start-Time: 1704577150708
< Server: istio-envoy
< X-Content-Type-Options: nosniff
< X-Envoy-Upstream-Service-Time: 27
< 
< {
<  "path": "/info",
<  "host": "foo.com",
<  "method": "GET",
<  "proto": "HTTP/1.1",
<  "headers": {
<   "Accept-Encoding": [
<    "gzip"
<   ],
<   "Original-Host": [
<    "foo.com"
<   ],
<   "Req-Start-Time": [
<    "1704577150678"
<   ],
<   "User-Agent": [
<    "Go-http-client/1.1"
<   ],
<   "X-B3-Sampled": [
<    "0"
<   ],
<   "X-B3-Spanid": [
<    "e098143fdb025c78"
<   ],
<   "X-B3-Traceid": [
<    "9e2c95aff2973c44e098143fdb025c78"
<   ],
<   "X-Echo-Set-Header": [
<    ""
<   ],
<   "X-Envoy-Attempt-Count": [
<    "1"
<   ],
<   "X-Envoy-Decorator-Operation": [
<    "infra-backend-v1.higress-conformance-infra.svc.cluster.local:8080/*"
<   ],
<   "X-Envoy-Internal": [
<    "true"
<   ],
<   "X-Forwarded-For": [
<    "192.168.65.1"
<   ],
<   "X-Forwarded-Proto": [
<    "http"
<   ],
<   "X-Real-Ip": [
<    "10.0.0.1"
<   ],
<   "X-Request-Id": [
<    "26590565-af76-4463-a43d-dde9289fcf1e"
<   ]
<  },
<  "namespace": "higress-conformance-infra",
<  "ingress": "",
<  "service": "",
<  "pod": "infra-backend-v1-55b649759b-79klt"
< }

Sending Request:
< GET /info HTTP/1.1
< Host: foo.com
< User-Agent: Go-http-client/1.1
< X-Echo-Set-Header: 
< X-Real-Ip: 10.0.0.1
< Accept-Encoding: gzip
< 
< 

Received Response:
< HTTP/1.1 200 OK
< Content-Length: 946
< Content-Type: application/json
< Date: Sat, 06 Jan 2024 21:39:10 GMT
< Req-Arrive-Time: 1704577150717
< Req-Cost-Time: 41
< Resp-Start-Time: 1704577150758
< Server: istio-envoy
< X-Content-Type-Options: nosniff
< X-Envoy-Upstream-Service-Time: 40
< 
< {
<  "path": "/info",
<  "host": "foo.com",
<  "method": "GET",
<  "proto": "HTTP/1.1",
<  "headers": {
<   "Accept-Encoding": [
<    "gzip"
<   ],
<   "Original-Host": [
<    "foo.com"
<   ],
<   "Req-Start-Time": [
<    "1704577150717"
<   ],
<   "User-Agent": [
<    "Go-http-client/1.1"
<   ],
<   "X-B3-Sampled": [
<    "0"
<   ],
<   "X-B3-Spanid": [
<    "fb89cb20ee8f98a0"
<   ],
<   "X-B3-Traceid": [
<    "47a84500ad20cd49fb89cb20ee8f98a0"
<   ],
<   "X-Echo-Set-Header": [
<    ""
<   ],
<   "X-Envoy-Attempt-Count": [
<    "1"
<   ],
<   "X-Envoy-Decorator-Operation": [
<    "infra-backend-v1.higress-conformance-infra.svc.cluster.local:8080/*"
<   ],
<   "X-Envoy-Internal": [
<    "true"
<   ],
<   "X-Forwarded-For": [
<    "192.168.65.1"
<   ],
<   "X-Forwarded-Proto": [
<    "http"
<   ],
<   "X-Real-Ip": [
<    "10.0.0.1"
<   ],
<   "X-Request-Id": [
<    "b21a8100-821e-4bb8-ab0f-2e37d8140e55"
<   ]
<  },
<  "namespace": "higress-conformance-infra",
<  "ingress": "",
<  "service": "",
<  "pod": "infra-backend-v1-55b649759b-fzvbp"
< }

Sending Request:
< GET /info HTTP/1.1
< Host: foo.com
< User-Agent: Go-http-client/1.1
< X-Echo-Set-Header: 
< X-Real-Ip: 10.0.0.1
< Accept-Encoding: gzip
< 
< 

Received Response:
< HTTP/1.1 200 OK
< Content-Length: 946
< Content-Type: application/json
< Date: Sat, 06 Jan 2024 21:39:10 GMT
< Req-Arrive-Time: 1704577150761
< Req-Cost-Time: 4
< Resp-Start-Time: 1704577150766
< Server: istio-envoy
< X-Content-Type-Options: nosniff
< X-Envoy-Upstream-Service-Time: 4
< 
< {
<  "path": "/info",
<  "host": "foo.com",
<  "method": "GET",
<  "proto": "HTTP/1.1",
<  "headers": {
<   "Accept-Encoding": [
<    "gzip"
<   ],
<   "Original-Host": [
<    "foo.com"
<   ],
<   "Req-Start-Time": [
<    "1704577150761"
<   ],
<   "User-Agent": [
<    "Go-http-client/1.1"
<   ],
<   "X-B3-Sampled": [
<    "0"
<   ],
<   "X-B3-Spanid": [
<    "4c97cb5592ea1e3a"
<   ],
<   "X-B3-Traceid": [
<    "c6ce79bf16fb3b994c97cb5592ea1e3a"
<   ],
<   "X-Echo-Set-Header": [
<    ""
<   ],
<   "X-Envoy-Attempt-Count": [
<    "1"
<   ],
<   "X-Envoy-Decorator-Operation": [
<    "infra-backend-v1.higress-conformance-infra.svc.cluster.local:8080/*"
<   ],
<   "X-Envoy-Internal": [
<    "true"
<   ],
<   "X-Forwarded-For": [
<    "192.168.65.1"
<   ],
<   "X-Forwarded-Proto": [
<    "http"
<   ],
<   "X-Real-Ip": [
<    "10.0.0.1"
<   ],
<   "X-Request-Id": [
<    "7b83869d-3350-4b22-ac99-dcae83398586"
<   ]
<  },
<  "namespace": "higress-conformance-infra",
<  "ingress": "",
<  "service": "",
<  "pod": "infra-backend-v1-55b649759b-fzvbp"
< }

    http.go:263: Request passed
    go-wasm-ip-restriction.go:114: Making GET request to http://localhost/info
Sending Request:
< GET /info HTTP/1.1
< Host: foo.com
< User-Agent: Go-http-client/1.1
< X-Echo-Set-Header: 
< X-Real-Ip: 10.0.0.2
< Accept-Encoding: gzip
< 
< 

Received Response:
< HTTP/1.1 403 Forbidden
< Content-Length: 45
< Content-Type: text/plain
< Date: Sat, 06 Jan 2024 21:39:10 GMT
< Server: istio-envoy
< 
< {"message":"Your IP address is not allowed."}

Sending Request:
< GET /info HTTP/1.1
< Host: foo.com
< User-Agent: Go-http-client/1.1
< X-Echo-Set-Header: 
< X-Real-Ip: 10.0.0.2
< Accept-Encoding: gzip
< 
< 

Received Response:
< HTTP/1.1 403 Forbidden
< Content-Length: 45
< Content-Type: text/plain
< Date: Sat, 06 Jan 2024 21:39:10 GMT
< Server: istio-envoy
< 
< {"message":"Your IP address is not allowed."}

Sending Request:
< GET /info HTTP/1.1
< Host: foo.com
< User-Agent: Go-http-client/1.1
< X-Echo-Set-Header: 
< X-Real-Ip: 10.0.0.2
< Accept-Encoding: gzip
< 
< 

Received Response:
< HTTP/1.1 403 Forbidden
< Content-Length: 45
< Content-Type: text/plain
< Date: Sat, 06 Jan 2024 21:39:10 GMT
< Server: istio-envoy
< 
< {"message":"Your IP address is not allowed."}

    http.go:263: Request passed
    go-wasm-ip-restriction.go:114: Making GET request to http://localhost/info
Sending Request:
< GET /info HTTP/1.1
< Host: foo.com
< User-Agent: Go-http-client/1.1
< X-Echo-Set-Header: 
< X-Real-Ip: 192.168.1.1
< Accept-Encoding: gzip
< 
< 

Received Response:
< HTTP/1.1 403 Forbidden
< Content-Length: 45
< Content-Type: text/plain
< Date: Sat, 06 Jan 2024 21:39:10 GMT
< Server: istio-envoy
< 
< {"message":"Your IP address is not allowed."}

Sending Request:
< GET /info HTTP/1.1
< Host: foo.com
< User-Agent: Go-http-client/1.1
< X-Echo-Set-Header: 
< X-Real-Ip: 192.168.1.1
< Accept-Encoding: gzip
< 
< 

Received Response:
< HTTP/1.1 403 Forbidden
< Content-Length: 45
< Content-Type: text/plain
< Date: Sat, 06 Jan 2024 21:39:10 GMT
< Server: istio-envoy
< 
< {"message":"Your IP address is not allowed."}

Sending Request:
< GET /info HTTP/1.1
< Host: foo.com
< User-Agent: Go-http-client/1.1
< X-Echo-Set-Header: 
< X-Real-Ip: 192.168.1.1
< Accept-Encoding: gzip
< 
< 

Received Response:
< HTTP/1.1 403 Forbidden
< Content-Length: 45
< Content-Type: text/plain
< Date: Sat, 06 Jan 2024 21:39:10 GMT
< Server: istio-envoy
< 
< {"message":"Your IP address is not allowed."}

    http.go:263: Request passed
    go-wasm-ip-restriction.go:114: Making GET request to http://localhost/info
Sending Request:
< GET /info HTTP/1.1
< Host: foo.com
< User-Agent: Go-http-client/1.1
< X-Echo-Set-Header: 
< X-Real-Ip: 192.168.0.1
< Accept-Encoding: gzip
< 
< 

Received Response:
< HTTP/1.1 200 OK
< Content-Length: 949
< Content-Type: application/json
< Date: Sat, 06 Jan 2024 21:39:10 GMT
< Req-Arrive-Time: 1704577150793
< Req-Cost-Time: 3
< Resp-Start-Time: 1704577150797
< Server: istio-envoy
< X-Content-Type-Options: nosniff
< X-Envoy-Upstream-Service-Time: 3
< 
< {
<  "path": "/info",
<  "host": "foo.com",
<  "method": "GET",
<  "proto": "HTTP/1.1",
<  "headers": {
<   "Accept-Encoding": [
<    "gzip"
<   ],
<   "Original-Host": [
<    "foo.com"
<   ],
<   "Req-Start-Time": [
<    "1704577150793"
<   ],
<   "User-Agent": [
<    "Go-http-client/1.1"
<   ],
<   "X-B3-Sampled": [
<    "0"
<   ],
<   "X-B3-Spanid": [
<    "660156d0270e9f71"
<   ],
<   "X-B3-Traceid": [
<    "bb1fa2231419cab9660156d0270e9f71"
<   ],
<   "X-Echo-Set-Header": [
<    ""
<   ],
<   "X-Envoy-Attempt-Count": [
<    "1"
<   ],
<   "X-Envoy-Decorator-Operation": [
<    "infra-backend-v1.higress-conformance-infra.svc.cluster.local:8080/*"
<   ],
<   "X-Envoy-Internal": [
<    "true"
<   ],
<   "X-Forwarded-For": [
<    "192.168.65.1"
<   ],
<   "X-Forwarded-Proto": [
<    "http"
<   ],
<   "X-Real-Ip": [
<    "192.168.0.1"
<   ],
<   "X-Request-Id": [
<    "25ef2479-3f78-476c-87a6-a8ef09eee3a3"
<   ]
<  },
<  "namespace": "higress-conformance-infra",
<  "ingress": "",
<  "service": "",
<  "pod": "infra-backend-v1-55b649759b-79klt"
< }

Sending Request:
< GET /info HTTP/1.1
< Host: foo.com
< User-Agent: Go-http-client/1.1
< X-Echo-Set-Header: 
< X-Real-Ip: 192.168.0.1
< Accept-Encoding: gzip
< 
< 

Received Response:
< HTTP/1.1 200 OK
< Content-Length: 949
< Content-Type: application/json
< Date: Sat, 06 Jan 2024 21:39:10 GMT
< Req-Arrive-Time: 1704577150801
< Req-Cost-Time: 2
< Resp-Start-Time: 1704577150803
< Server: istio-envoy
< X-Content-Type-Options: nosniff
< X-Envoy-Upstream-Service-Time: 1
< 
< {
<  "path": "/info",
<  "host": "foo.com",
<  "method": "GET",
<  "proto": "HTTP/1.1",
<  "headers": {
<   "Accept-Encoding": [
<    "gzip"
<   ],
<   "Original-Host": [
<    "foo.com"
<   ],
<   "Req-Start-Time": [
<    "1704577150801"
<   ],
<   "User-Agent": [
<    "Go-http-client/1.1"
<   ],
<   "X-B3-Sampled": [
<    "0"
<   ],
<   "X-B3-Spanid": [
<    "c09de19a0428596d"
<   ],
<   "X-B3-Traceid": [
<    "2254caab0f769626c09de19a0428596d"
<   ],
<   "X-Echo-Set-Header": [
<    ""
<   ],
<   "X-Envoy-Attempt-Count": [
<    "1"
<   ],
<   "X-Envoy-Decorator-Operation": [
<    "infra-backend-v1.higress-conformance-infra.svc.cluster.local:8080/*"
<   ],
<   "X-Envoy-Internal": [
<    "true"
<   ],
<   "X-Forwarded-For": [
<    "192.168.65.1"
<   ],
<   "X-Forwarded-Proto": [
<    "http"
<   ],
<   "X-Real-Ip": [
<    "192.168.0.1"
<   ],
<   "X-Request-Id": [
<    "74ba572b-e85a-46b6-b0b7-8ca51961faf6"
<   ]
<  },
<  "namespace": "higress-conformance-infra",
<  "ingress": "",
<  "service": "",
<  "pod": "infra-backend-v1-55b649759b-fzvbp"
< }

Sending Request:
< GET /info HTTP/1.1
< Host: foo.com
< User-Agent: Go-http-client/1.1
< X-Echo-Set-Header: 
< X-Real-Ip: 192.168.0.1
< Accept-Encoding: gzip
< 
< 

Received Response:
< HTTP/1.1 200 OK
< Content-Length: 949
< Content-Type: application/json
< Date: Sat, 06 Jan 2024 21:39:10 GMT
< Req-Arrive-Time: 1704577150806
< Req-Cost-Time: 3
< Resp-Start-Time: 1704577150809
< Server: istio-envoy
< X-Content-Type-Options: nosniff
< X-Envoy-Upstream-Service-Time: 3
< 
< {
<  "path": "/info",
<  "host": "foo.com",
<  "method": "GET",
<  "proto": "HTTP/1.1",
<  "headers": {
<   "Accept-Encoding": [
<    "gzip"
<   ],
<   "Original-Host": [
<    "foo.com"
<   ],
<   "Req-Start-Time": [
<    "1704577150806"
<   ],
<   "User-Agent": [
<    "Go-http-client/1.1"
<   ],
<   "X-B3-Sampled": [
<    "0"
<   ],
<   "X-B3-Spanid": [
<    "e781a8da28922b94"
<   ],
<   "X-B3-Traceid": [
<    "f6a68b128d224598e781a8da28922b94"
<   ],
<   "X-Echo-Set-Header": [
<    ""
<   ],
<   "X-Envoy-Attempt-Count": [
<    "1"
<   ],
<   "X-Envoy-Decorator-Operation": [
<    "infra-backend-v1.higress-conformance-infra.svc.cluster.local:8080/*"
<   ],
<   "X-Envoy-Internal": [
<    "true"
<   ],
<   "X-Forwarded-For": [
<    "192.168.65.1"
<   ],
<   "X-Forwarded-Proto": [
<    "http"
<   ],
<   "X-Real-Ip": [
<    "192.168.0.1"
<   ],
<   "X-Request-Id": [
<    "f886a0ff-9443-4153-affe-d25df45f73f3"
<   ]
<  },
<  "namespace": "higress-conformance-infra",
<  "ingress": "",
<  "service": "",
<  "pod": "infra-backend-v1-55b649759b-fzvbp"
< }

    http.go:263: Request passed
=== CONT  TestHigressConformanceTests/WasmPluginsIpRestriction
    apply.go:157: 🚮 Deleting ip-restriction WasmPlugin
    apply.go:157: 🚮 Deleting httproute-app-root Ingress
=== CONT  TestHigressConformanceTests
    apply.go:113: 🚮 Deleting tls-validity-checks-certificate 
    apply.go:113: 🚮 Deleting certificate 
    apply.go:157: 🚮 Deleting nacos-standlone-rc3-service Service
    apply.go:157: 🚮 Deleting nacos-standlone-rc3 Pod
    apply.go:157: 🚮 Deleting dubbo-demo-provider Pod
    apply.go:157: 🚮 Deleting httpbin Pod
    apply.go:157: 🚮 Deleting consul-service Service
    apply.go:157: 🚮 Deleting consul-standlone Pod
    apply.go:157: 🚮 Deleting web-backend Deployment
    apply.go:157: 🚮 Deleting web-backend Service
    apply.go:157: 🚮 Deleting higress-conformance-web-backend Namespace
    apply.go:157: 🚮 Deleting app-backend-v2 Deployment
    apply.go:157: 🚮 Deleting app-backend-v2 Service
    apply.go:157: 🚮 Deleting app-backend-v1 Deployment
    apply.go:157: 🚮 Deleting app-backend-v1 Service
    apply.go:157: 🚮 Deleting higress-conformance-app-backend Namespace
    apply.go:157: 🚮 Deleting infra-backend-v3 Deployment
    apply.go:157: 🚮 Deleting infra-backend-v3 Service
    apply.go:157: 🚮 Deleting infra-backend-v2 Deployment
    apply.go:157: 🚮 Deleting infra-backend-v2 Service
    apply.go:157: 🚮 Deleting infra-backend-v1 Deployment
    apply.go:157: 🚮 Deleting infra-backend-v1 Service
    apply.go:157: 🚮 Deleting higress-conformance-infra Namespace
--- PASS: TestHigressConformanceTests (23.40s)
    --- PASS: TestHigressConformanceTests/WasmPluginsIpRestriction (1.17s)
        --- PASS: TestHigressConformanceTests/WasmPluginsIpRestriction/WasmPlugins_ip-restriction (1.14s)
PASS
ok      command-line-arguments  23.832s

test in k8s cluster locally

kubectl port-forward service/higress-gateway -n higress-system 1080:80 1443:443
Forwarding from 127.0.0.1:1080 -> 80
Forwarding from [::1]:1080 -> 80
Forwarding from 127.0.0.1:1443 -> 443
Forwarding from [::1]:1443 -> 443
Handling connection for 1080
Handling connection for 1080
Handling connection for 1080

curl http://localhost:1080/foo -H 'host: foo.bar.com' -H 'X-REAL-IP: 10.0.0.1'
foo
curl http://localhost:1080/foo -H 'host: foo.bar.com' -H 'X-REAL-IP: 10.0.3.0'
{"message":"Your IP address is not allowed."}%

Ⅴ. Special notes for reviews

CLAassistant · 2024-01-06T22:11:24Z

All committers have signed the CLA.

Renz7 · 2024-01-07T13:27:23Z

#607

plugins/wasm-go/extensions/ip-restriction/main.go

WeixinX · 2024-01-09T07:37:33Z

@Renz7, @johnlanni 想请教一下为什么 IP 是通过请求头进行获取，而不是使用 proxywasm.GetProperty([]string{"source","address"})

Renz7 · 2024-01-09T08:22:45Z

@Renz7, @johnlanni 想请教一下为什么 IP 是通过请求头进行获取，而不是使用 proxywasm.GetProperty([]string{"source","address"})

你说的有道理，查了下相关的文档

johnlanni · 2024-01-09T08:23:38Z

是的应该用这个：
proxywasm.GetProperty([]string{"source","address"})

johnlanni · 2024-01-09T08:24:40Z

可以加个配置，允许用户配置ip来源：

remote ip
xff header
自定义header，例如 x-real-ip

johnlanni · 2024-01-26T08:26:09Z

cc @WeixinX

johnlanni · 2024-02-02T09:01:24Z

@SpecialYang 支持IP黑白名单的插件，有空一起review下

WeixinX

其他的我认为没什么问题 ~

plugins/wasm-go/extensions/ip-restriction/main.go

plugins/wasm-go/extensions/ip-restriction/utils.go

plugins/wasm-go/extensions/ip-restriction/README.md

plugins/wasm-go/extensions/ip-restriction/main.go

test/e2e/conformance/tests/go-wasm-ip-restriction.yaml

johnlanni · 2024-03-03T03:31:01Z

@Renz7 请再按上述要求做一下代码调整，调整完成后我将代码合入

Renz7 · 2024-03-03T04:24:46Z

@Renz7 请再按上述要求做一下代码调整，调整完成后我将代码合入

OK 我尽快

…#689)

…-agent (alibaba#827)

Signed-off-by: spacewander <[email protected]>

Co-authored-by: Xunzhuo <[email protected]>

Renz7 · 2024-03-05T02:35:35Z

@Renz7 请再按上述要求做一下代码调整，调整完成后我将代码合入

OK 我尽快

@johnlanni @WeixinX PTAL

johnlanni

LGTM

codecov-commenter · 2024-03-05T02:56:53Z

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.16%. Comparing base (cc6043d) to head (c297936).

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #759      +/-   ##
==========================================
+ Coverage   38.13%   38.16%   +0.02%     
==========================================
  Files          61       61              
  Lines       10436    10436              
==========================================
+ Hits         3980     3983       +3     
+ Misses       6156     6154       -2     
+ Partials      300      299       -1

see 1 file with indirect coverage changes

Renz7 requested review from 2456868764, CH3CHO, WeixinX, Xunzhuo and johnlanni as code owners January 6, 2024 22:11

johnlanni requested changes Jan 8, 2024

View reviewed changes

plugins/wasm-go/extensions/ip-restriction/main.go Outdated Show resolved Hide resolved

plugins/wasm-go/extensions/ip-restriction/main.go Show resolved Hide resolved

Renz7 marked this pull request as draft January 9, 2024 08:23

Renz7 force-pushed the ip-restriction branch from 508dfa8 to b794465 Compare January 23, 2024 05:17

Renz7 marked this pull request as ready for review January 23, 2024 05:29

Renz7 added 3 commits January 29, 2024 16:07

feat: add ip-restriction wasm-go plugin

4675ec0

feat: radix tree store; update deny allow policy

0098f26

feat: multi IP source support

ff7f87c

Renz7 force-pushed the ip-restriction branch from b794465 to ff7f87c Compare January 29, 2024 08:07

WeixinX reviewed Feb 17, 2024

View reviewed changes

plugins/wasm-go/extensions/ip-restriction/main.go Outdated Show resolved Hide resolved

plugins/wasm-go/extensions/ip-restriction/utils.go Outdated Show resolved Hide resolved

johnlanni requested changes Feb 20, 2024

View reviewed changes

plugins/wasm-go/extensions/ip-restriction/README.md Outdated Show resolved Hide resolved

johnlanni requested changes Feb 20, 2024

View reviewed changes

plugins/wasm-go/extensions/ip-restriction/main.go Show resolved Hide resolved

test/e2e/conformance/tests/go-wasm-ip-restriction.yaml Show resolved Hide resolved

baerwang and others added 4 commits March 4, 2024 16:40

feat: wasm support opa (Open Policy Agent) (alibaba#760)

0060089

bugfix: "path=/" will cause panic (alibaba#809)

66ab4e2

Enable srds by default (alibaba#811)

a1457dc

rel: Release verion 1.3.4-rc.2 (alibaba#812)

442acaa

johnlanni and others added 17 commits March 4, 2024 16:40

Update build-image-and-push.yaml

d736a21

Update build-image-and-push.yaml

ae46187

Update Makefile.core.mk

961279f

feat: implement custom-response plugin in the golang version (alibaba…

2ac31d3

…#689)

Increase health check timeout of the first readiness probe from pilot…

b0aaced

…-agent (alibaba#827)

test: allow specifying HTTP protocol (alibaba#822)

61454a2

Signed-off-by: spacewander <[email protected]>

rel: Release verison 1.3.4 (alibaba#828)

cb4856d

optimize: add klog for debuging requests with apiserver (alibaba#830)

7cc3a9a

fix: content-type not work in custom response plugin (alibaba#833)

ddb99c1

feat: hgctl install profile support resource configuration (alibaba#823)

0975d3b

chore: e2e build wasm plugin retry (alibaba#838)

6d1a255

feat: custom listening port for gateway pod in helm (alibaba#829)

e663035

Support redis call (alibaba#756)

3513265

Co-authored-by: Xunzhuo <[email protected]>

replace proxy-wasm-go-sdk (alibaba#842)

78ec968

Update build-and-test-plugin.yaml

75d35d1

support nil wasmplugin config in ingress-level (alibaba#852)

0733993

feat: add e2e test

6d0c2af

Renz7 requested review from SpecialYang and gengleilei as code owners March 4, 2024 08:44

Renz7 and others added 2 commits March 4, 2024 16:45

Merge branch 'main' into ip-restriction

34e50fb

fix: modify e2e test

a5345e3

johnlanni approved these changes Mar 5, 2024

View reviewed changes

Update README.md

05414df

Renz7 added 2 commits March 6, 2024 10:38

Merge branch 'main' into ip-restriction

6456ad0

Merge branch 'main' into ip-restriction

c297936

johnlanni merged commit 3128df9 into alibaba:main Mar 12, 2024

VinceCui pushed a commit to VinceCui/higress that referenced this pull request May 21, 2025

feat: add ip-restriction wasm-go plugin (alibaba#759)

6c5dbb4

ink-hz pushed a commit to ink-hz/higress-ai-capability-auth that referenced this pull request Nov 5, 2025

feat: add ip-restriction wasm-go plugin (alibaba#759)

6deb761

feat: add ip-restriction wasm-go plugin #759

feat: add ip-restriction wasm-go plugin #759

Uh oh!

Conversation

Renz7 commented Jan 6, 2024 • edited by johnlanni Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Ⅰ. Describe what this PR did

Ⅱ. Does this pull request fix one issue?

Ⅲ. Why don't you add test cases (unit test/integration test)?

Ⅳ. Describe how to verify it

Ⅴ. Special notes for reviews

Uh oh!

CLAassistant commented Jan 6, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Renz7 commented Jan 7, 2024

Uh oh!

Uh oh!

Uh oh!

WeixinX commented Jan 9, 2024

Uh oh!

Renz7 commented Jan 9, 2024

Uh oh!

johnlanni commented Jan 9, 2024

Uh oh!

johnlanni commented Jan 9, 2024

Uh oh!

johnlanni commented Jan 26, 2024

Uh oh!

johnlanni commented Feb 2, 2024

Uh oh!

WeixinX left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

johnlanni commented Mar 3, 2024

Uh oh!

Renz7 commented Mar 3, 2024

Uh oh!

Renz7 commented Mar 5, 2024

Uh oh!

johnlanni left a comment

Choose a reason for hiding this comment

Uh oh!

codecov-commenter commented Mar 5, 2024 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

13 participants

Renz7 commented Jan 6, 2024 •

edited by johnlanni

Loading

CLAassistant commented Jan 6, 2024 •

edited

Loading

codecov-commenter commented Mar 5, 2024 •

edited

Loading