fix: recover component lifecycle and avoid execute from scope __proto__#2681
Merged
fix: recover component lifecycle and avoid execute from scope __proto__#2681
Conversation
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🔴 | Statements | 33.63% | 114/339 |
| 🔴 | Branches | 14.53% | 25/172 |
| 🔴 | Functions | 26.14% | 23/88 |
| 🔴 | Lines | 34.23% | 114/333 |
Test suite run success
2 tests passing in 1 suite.
Report generated by 🧪jest coverage report action from fb8ef33
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 80.96% | 370/457 |
| 🟡 | Branches | 76.65% | 279/364 |
| 🟢 | Functions | 88.7% | 102/115 |
| 🟢 | Lines | 81.36% | 358/440 |
Test suite run success
234 tests passing in 40 suites.
Report generated by 🧪jest coverage report action from fb8ef33
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟡 | Statements | 72.62% (+0.15% 🔼) |
915/1260 |
| 🟡 | Branches | 61.34% (-0.26% 🔻) |
576/939 |
| 🟡 | Functions | 70% (+1.47% 🔼) |
196/280 |
| 🟡 | Lines | 72.68% (+0.15% 🔼) |
899/1237 |
Show files with reduced coverage 🔻
St.❔ |
File | Statements | Branches | Functions | Lines |
|---|---|---|---|---|---|
| 🟡 | renderer/base.tsx | 66.24% (-0.49% 🔻) |
54.01% (-0.58% 🔻) |
64.29% | 66.31% (-0.5% 🔻) |
Test suite run success
101 tests passing in 8 suites.
Report generated by 🧪jest coverage report action from fb8ef33
Coverage report for
|
St.❔ |
Category | Percentage | Covered / Total |
|---|---|---|---|
| 🟢 | Statements | 96.09% | 2853/2969 |
| 🟢 | Branches | 88.6% | 1625/1834 |
| 🟢 | Functions | 95.67% | 862/901 |
| 🟢 | Lines | 96.16% | 2778/2889 |
Test suite run success
378 tests passing in 43 suites.
Report generated by 🧪jest coverage report action from fb8ef33
Collaborator
|
1.2.3-beta.4 |
我把engine-core更新到了这个版本, 但低代码组件的生命周期依然没有执行, 而且连Page本身的生命周期也没有执行了 |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
修复低代码组件生命周期方法未执行的问题