Merged
Conversation
eternalsky
reviewed
Aug 21, 2023
| onResizeStart: (e, currentNode) => { | ||
| const parent = currentNode.getParent(); | ||
| onResizeStart: (e, currentNode: INode) => { | ||
| const parent = currentNode.parent; |
Collaborator
There was a problem hiding this comment.
感觉这里是唯一的逻辑修改点,但是没看懂和修复的 bug 之间的关系
Collaborator
Author
There was a problem hiding this comment.
引擎bug是没有抛出正确的错误,在这个 PR 里面修复了。
这个错误修复之后,会抛出物料的错误,就是 getParent is not a funtion.
eternalsky
approved these changes
Aug 21, 2023
Collaborator
|
@alifd/fusion-ui@2.0.3 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fixed alibaba/lowcode-engine#2390