This repository was archived by the owner on Apr 15, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1
UI building blocks #4
Open
alice-i-cecile
wants to merge
24
commits into
main
Choose a base branch
from
ui-building-blocks
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, you probably shouldn't be numbering them until they are accepted, and just keep the number as 000 (or at least number them based on the PR number) |
Ah, this is good practice. I was wondering how we'd handle that in a distributed way. |
Full credit, blame and thanks go to @BoxyUwU for this cursed magic
d3f562f
to
b5584c3
Compare
Must refer to either Base or Final; the underlying type has no meaning.
alice-i-cecile
added a commit
to alice-i-cecile/rfcs
that referenced
this pull request
Apr 14, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Building blocks for an ECS-based UI solution
To be ported to the official Bevy RFC repo.