Crash when deserializing a HttpResponseMessage on .NET Core

[JimiSmith]

On .NET Core (I've tested 2.0 and 2.1) calling DeserializeToResponseAsync on MessageContentHttpMessageSerializer will crash with certain http responses. (google.com being one of them)

I've tested this on 4.7.1 and the crash does not occur. I'm guessing this may be a framework issue, but I'm not 100% sure.

I've attached a project that reproduces the problem

Exception backtrace

System.InvalidOperationException: Error parsing HTTP message header byte 697 of message System.Byte[].
   at System.Net.Http.HttpContentMessageExtensions.ReadAsHttpResponseMessageAsyncCore(HttpContent content, Int32 bufferSize, Int32 maxHeaderSize, CancellationToken cancellationToken)
   at CacheCow.Client.MessageContentHttpMessageSerializer.DeserializeToResponseAsync(Stream stream)
   at CacheCowCrashRepro.TestCacheStore.AddOrUpdateAsync(CacheKey key, HttpResponseMessage response) in C:\Users\james\Documents\Projects\CacheCowCrashRepro\CacheCowCrashRepro\Program.cs:line 45
   at CacheCow.Client.CachingHandler.SendAsync(HttpRequestMessage request, CancellationToken cancellationToken)
   at System.Net.Http.HttpClient.FinishSendAsyncBuffered(Task`1 sendTask, HttpRequestMessage request, CancellationTokenSource cts, Boolean disposeCts)
   at CacheCowCrashRepro.Program.Main(String[] args) in C:\Users\james\Documents\Projects\CacheCowCrashRepro\CacheCowCrashRepro\Program.cs:line 19}	System.Exception {System.InvalidOperationException

CacheCowCrashRepro.zip

Thanks

[JimiSmith]

This is the contents of the serialized HttpResponseMessage. It looks normal to me

cache-cow-http-response-crash.txt

[aliostad]

Interesting problem. Thanks for reporting. I will have a look and get back to you soon.

[aliostad]

It is seems to be a bug in .NET Core 2.1. Works with 2.0. Please follow-up this github issue.

https://github.com/dotnet/corefx/issues/31918

[JimiSmith]

Thanks :) And thanks for the great library

[aliostad]

Re-opening to keep track. The issue currently is here:
aspnet/AspNetWebStack#193 (comment)

[aliostad]

There is some breakthrough (finally) with the issue and it is a bug in the .NET Framework from 2.0 to 2.1. Hopefully fixed soon. Thank you for reporting it.

[pietervdvn]

Hey,

While testing and bugfixing, I encountered a similar issue. It turns out that the Server-header is the culprit.

Removing this part of the header with response.Headers.Remove("Server"); is a viable workaround.

I'm gonna report this upstream too.

[aliostad]

@pietervdvn thanks for the tip. Issue seems to be in Expires header and waiting for the resolution from Microsoft.

[pietervdvn]

NP. I could parse expire headers just fine (although I'm on dotnetcore 2.0).

[aliostad]

Now it is being followed here
https://github.com/dotnet/corefx/issues/31918