Draft
Conversation
8 tasks
Collaborator
|
Hey- can you try out the revision? I was getting errors running the tests before, so I refactored a bit. Now it's using the classes from v2 where possible. |
Contributor
Author
|
Perfect, nice that we could re-use more code from v2 classes, thanks! The changes look good, I started the tests, I think they will run for a while, and will report back when they still work. (but I think everything should work) |
Contributor
Author
|
Hi, an update from the tests, they still run on my machine and also the other scripts that I had still work, so everything seems to be fine from my side. |
Collaborator
|
Digging into this... |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Dear all,
with a focus on the current TREC Rag task, this is an initial implementation for accessing documents via the corpus_iter and the document store for the document and the segmented document datasets of MS MARCO v2.1.
This is not completely finished (i.e., mainly documentation todos in the corresponding tickets are open), but as the deadline is soon, this might be useful for others even when the documentation is not yet completed.