local umbrella charts support

[jkotiuk]

Hey,

I'm having an issue when trying to deploy an umbrella helm chart stored in a local repository. It's similar to the testdata cluster 9, but the local chart needs to specify dependencies in the Chart.yaml. It will error out saying that subcharts are not available due to missing helm dependency build.

The same setup is deployed without any issues by Flux itself, so it's supported there.

=========================== short test summary info ============================
FAILED clusters/local::tenant::default/tenant - flux_local.exceptions.HelmException: Command 'helm template tenant ./charts/tenant --namespace default --repository-cache /tmp/tmpqupj2sq5 --repository-config /tmp/tmp5513ljpe/repository-config.yaml --registry-config /dev/null --skip-crds --skip-tests --api-versions policy/v1/PodDisruptionBudget --values /tmp/tmp5513ljpe/default-tenant-values.yaml' failed with return code 1
Error: An error occurred while checking for chart dependencies. You may need to run `helm dependency build` to fetch missing dependencies: found in Chart.yaml, but missing in charts/ directory: app, redis
========================= 1 failed, 13 passed in 5.42s =========================

version: allenporter/flux-local/action/test@23b8f4e593254e34b2913728007c419b52789382 # 7.3.0

[allenporter]

Thanks for the report. I'm not familiar with what an umbrella chart is.

Would you be able to give a minimal repo example that can reproduce this or a subset of the set of files? what does the flux setup look like etc.

Thanks!

[jkotiuk]

An umbrella chart is a chart that specifies subcharts (dependencies). I've created PR with modified test data cluster9 that should trigger the same error. https://github.com/allenporter/flux-local/pull/884/files#diff-d3f06630a9df9036c9ec0e2c6ab9424093b37f3c2dca54cbe9516c3a4055987bR29-R32

nginx_subchart is renamed copy of existing nginx chart

If you go to the directory tests/testdata/cluster9/local-charts/nginx on my fork and execute helm template test . it will error out the same way as flux-local does because for subchart we have to run helm dependency build first

[allenporter]

Thank you for the test PR that reproduces the issue, very helpful.
I think a next step is to understand how the flux helm controller knows to run equivalent ofhelm dependency build -- e.g. if its always when referencing a git repo or something else.

[jkotiuk]

Looks like this is handled at the source controller https://github.com/fluxcd/source-controller/blob/main/internal/helm/chart/dependency_manager.go

It seems that after downloading the chart archive, it is building dependencies from the chart.yaml file and downloads the ones that are missing (some dependencies might be included as a part of the archive in charts/ directory)

How would you see it being implemented for flux-local?