Merged
Conversation
The ImageWidget takes an ImageProvider as parameter and renders as an image. The size of the element, if not specified, is automatically set to the image size.
Two changes to improve resizing of ImageWidget: - give users a better feedback with a gray background behind the image, - fit the image using BoxFit.contain so that it doesn't stretch
Author
|
Converting to draft as Image widget is missing save/load implementation. |
Collaborator
Suggestion: you could convert the image to base64 to save/load 😄 |
- refactor loadDashboard to split file read and data parsing - add loadDashboardData to create dashboard from json content - add Web support in the example to load and save dashboards
mauriziopinotti
force-pushed
the
image_widget
branch
from
899ee80 to
f973855
Compare
Add a new parameter backgroundImage to add a background image to the dashboard. The image moves and zooms along with the grid.
Old UniqueKey causes all elements to be re-drawn from scratch each time. With a ValueKey tied to the element id elements are not redrawn. This is particularily visible with the ImageWidget since its rendering is not istantaneous and the user notices the continuous loading.
mauriziopinotti
force-pushed
the
image_widget
branch
from
b535df1 to
2d16f33
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The ImageWidget takes an ImageProvider as parameter and renders as an image. The size of the element, if not specified, is automatically set to the image size.
Type of Change