Added PATCH method

[fpvmorais]

Hello,

This is just a tiny contribution, I'm currently running Emacs on a Windows SO and needed to create pull requests on DevAzure.
One of the endpoints demands the PATCH method.

Being using this for a few weeks and works properly.

One issue I've found is that it does not work with cURL from Microsoft located on C:\Windows\System32\curl.exe. (Version 8.4.0). Not sure exactly why.
After installing the Curl version (8.6.0) via Scoop and setting this variable on Emacs:
(setq plz-curl-program "C:\\Tools\\scoop\\apps\\curl\\current\\bin\\curl.exe")
Everything started working correctly. Not sure if it's worth it to add to the documentation, but it might help someone in the same situation as me.

Thank you so much for your amazing packages and work.
All the best from Portugal

Pedro

[alphapapa]

Hi Pedro,

Hello,

This is just a tiny contribution, I'm currently running Emacs on a Windows SO and needed to create pull requests on DevAzure. One of the endpoints demands the PATCH method.

Being using this for a few weeks and works properly.

Thanks, this looks good. And thanks for including a test. I'll plan to add this in the next version.

One issue I've found is that it does not work with cURL from Microsoft located on C:\Windows\System32\curl.exe. (Version 8.4.0). Not sure exactly why. After installing the Curl version (8.6.0) via Scoop and setting this variable on Emacs: (setq plz-curl-program "C:\\Tools\\scoop\\apps\\curl\\current\\bin\\curl.exe") Everything started working correctly. Not sure if it's worth it to add to the documentation, but it might help someone in the same situation as me.

Yes, Windows's "ersatz curl" presents some problems with argument handling compared to the real thing. We should mention that in the docs somewhere. Feel free to open an issue about that if you like.

By the way, this probably fits within the "tiny change" guidelines, but it would be good to complete the FSF Emacs copyright assignment process. Would you be willing to do that?

Thank you so much for your amazing packages and work. All the best from Portugal

Thanks for the kind words and your contribution.

[fpvmorais]

Sure I would be willing to complete the FSF Emacs copyright assignment process.
Can you please point me to where I could start that process?

Thanks

[alphapapa]

Sure, the way most people do it is to send a message to [email protected] and ask for the copyright assignment form to contribute to Emacs. Then the maintainers will send it to you with further instructions.

[fpvmorais]

Hello

I finally have the document. How should we proceed now?

[alphapapa]

Sorry for the delay. Been quite busy. Feel free to ping me if I overlook something now and then.

Anyway, I am not allowed to take anyone's word for having completed the copyright assignment process. I need to receive confirmation from the FSF secretary or one of the Emacs maintainers. So you should either ask one of them to send confirmation to me, or tell me the name and email address you used when executing the document so I can ask them for confirmation.

[fpvmorais]

Hi, I've used the email ***@***.*** and the name Fernando Pedro Viana Morais. All the best, Pedro Adam Porter ***@***.***> escreveu (sábado, 29/06/2024 à(s) 23:53):

…

Sorry for the delay. Been quite busy. Feel free to ping me if I overlook something now and then. Anyway, I am not allowed to take anyone's word for having completed the copyright assignment process. I need to receive confirmation from the FSF secretary or one of the Emacs maintainers. So you should either ask one of them to send confirmation to me, or tell me the name and email address you used when executing the document so I can ask them for confirmation. — Reply to this email directly, view it on GitHub <#49 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AFLT35Q7BH5A53FGQ7GGVZDZJ43FFAVCNFSM6AAAAABFLRQZGCVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCOJYGM3DMNBVGU> . You are receiving this because you authored the thread.Message ID: ***@***.***>

[alphapapa]

Hi Pedro,

Unfortunately, GitHub filters out the email addresses when you reply via email. So please either email me directly or contact the FSF secretary or Emacs maintainers and ask them to send confirmation to me.

Thanks.

[alphapapa]

I've received confirmation from the Emacs maintainers. I'll plan to merge this for v0.10.

[alphapapa]

Thanks for your patience. I didn't mean to neglect this. Feel free to ping me in the future if I forget about something. (I have a lot of Emacs projects and not enough time to tend to them all as I'd like.)

[fpvmorais]

I'm just happy to help!

I know you're very busy and I'm very grateful for many of your packages.

Good luck managing r/emacs :P

[alphapapa]

Thank you. It's already proving a bit tiring, with a few loud people "tilting at windmills" and practically daring me to ban them for being abusive toward me (was it Churchill who spoke about not being able to stand for something without having someone stand against you?). I didn't really want to be a mod on r/emacs, but I was asked to be, and I had said enough about how moderation ought to be done, that I could hardly refuse to serve. I hope that we can add more good moderators in the future, and then maybe I could step aside. Or maybe someday Reddit will just fade away...