fix(csp): skip sharedStorage when enumerating globalThis properties#4787
Merged
calebporzio merged 1 commit intoApr 1, 2026
Merged
Conversation
Collaborator
|
good catch. thanks |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
The CSP parser enumerates all
globalThisproperties to build a set of knownglobals. Accessing
window.sharedStoragetriggers Chrome's deprecation warning:This causes Lighthouse "Best Practices" score to drop from 100 to 81.
This is the same class of issue that was already fixed for
styleMedia.Solution
Add
"sharedStorage"to the skip list in the globalThis enumeration loop,alongside the already-skipped
"styleMedia".Testing
sharedStorageis not used by Alpine or typical web appsFixes #4788