Add admx for gsettings #27
Conversation
ghost
requested a review
from 
|
LGTM, I suppose we may test this PR before merging in case of doubts. |
|
|
||
| <string id="idle-activation-enabled">Enable org.mate.screensaver</string> | ||
| <string id="idle-activation-enabled_help"> | ||
| Enables desktop screen savers. If you disable this setting, screen savers do not run. Also, this setting disables the Screen Saver section of the Screen Saver dialog in the Personalization or Display Control Panel. As a result, users cannot change the screen saver options. If you do not configure it, this setting has no effect on the system. If you enable it, a screen saver runs, provided the following two conditions hold: First, a valid screen saver on the client is specified through the "Screen Saver executable name" setting or through Control Panel on the client computer. Second, the screen saver timeout is set to a nonzero value through the setting or Control Panel. Also, see the "Prevent changing Screen Saver" setting. |
There was a problem hiding this comment.
desktop screen savers
I'd use singular here, 'screen saver'
screen savers do not run
I'd use future here, 'won't run', or even 'won't be started'.
a screen saver runs
Using 'a' feels wrong here.
First, a valid screen saver on the client is specified through the "Screen Saver executable name" setting or through Control Panel on the client computer.
Let's call it 'the client machine' or 'the client system' for the first time, and drop the second.
|
|
||
| - Neither the "Screen saver executable name" setting nor the Screen Saver dialog of the client computer's Personalization or Display Control Panel specifies a valid existing screen saver program on the client. | ||
|
|
||
| When not configured, whatever wait time is set on the client through the Screen Saver dialog in the Personalization or Display Control Panel is used. The default is 15 minutes.</string> |
There was a problem hiding this comment.
It's somewhat unclear what default do you mean here. Is it the setting default when it's configured? Or default for client system when it's not?
| When not configured, whatever wait time is set on the client through the Screen Saver dialog in the Personalization or Display Control Panel is used. The default is 15 minutes.</string> | ||
|
|
||
| <string id="lock-enabled">Password protect the screen saver</string> | ||
| <string id="lock-enabled_help">Determines whether screen savers used on the computer are password protected. |
There was a problem hiding this comment.
To me, it's somewhat unclear what does it mean for a screen saver to be password-protected. I'd suggest to describe this explicitly, e.g.: "When enabled, the user session is locked when screen server starts, and the user have to enter his or her password to unlock it". Or idk.
In category Graphics I have added next admx: