-
Notifications
You must be signed in to change notification settings - Fork 3
Support downloading files directly into container #8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support downloading files directly into container #8
Conversation
@gedankenstuecke I'm not really comfortable with entering my username & password into a MyBinder notebook. Are there any alternatives to this (e.g. copying the |
@gy-mate I totally understand! I think your suggestion should work, do you want to give it a try by adapting the |
I've now merged in @iandees' amazing work on getting the timelapse gifs done into this as well, you can give it a try here. This still assumes logging into Geofabrik through the notebook itself instead of uploading a cookie or copy/pasting the cookie value. |
Co-authored-by: Máté Gyöngyösi <[email protected]>
I've added your approach in, just slightly modified to also accept the "copy" of a cookie one can get in Firefox and automatically adjusting the input for that or the one you provided @gy-mate. I've also written up the documentation for how one would get to access the cookie data (expansions for other browsers are welcome!) and then structured the how-to a bit more, as now we have 3 ways of getting OSM history files. I'm waiting for my binder to launch to see if it all still works fine there! |
Okay, tried and it still all works as expected, from my side I'd say it's good for merging! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for adding my suggestions! :)
Just a few grammar fixes.
Co-authored-by: Máté Gyöngyösi <[email protected]>
Perfect, thanks so much! Any concerns to this being merged in? (@amandasaurus do you want to press the button if you agree? it feels wrong for me to merge my own PR 😂) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've read this and nothing jumps out to me as strange. I haven't run it yet, so I trust you there. 😅
I must commend you again on making this software much easier to use for more people. 👏🏻🙏🏻 It's sometimes boring work, to write documentation and instructions, but it really does help people. Thank you! 😁😁😁
Thanks so much! 🙏 Seeing people on Mastodon test it and making their first images has been amazing, I'm so glad if it helps more people to use the data! |
As discussed in the comments to this PR, and thanks to the great suggestion by @amandasaurus, this PR adds the ability to download OSM history files directly from Geofabrik into the running docker container.
This is particularly useful when running on MyBinder, as it sidesteps the need to first get a local copy for then re-uploading it, making downloads a lot faster as they are from one cloud into the next, e.g. for the download of the history file for Argentina:
Happy to refactor this once #7 is merged in, just wanted to signpost this now already!