Fix Jinja2 dependency #689
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jinja2 version 2.11 has a broken dependency constraint that allows its dependency on markupsafe to pull in a version that it is not actually compatible with the interface of. Fix this by upgrading the dependency to `~=3.0`. This requires a small patch to the code to replace the deprecated `@jinja2.contextfunction` decorator with the replacement `@jinja2.pass_context`since `@jinja2.contextfunction` is removed in Jinja2 version 3.1.0.
Codecov Report
@@ Coverage Diff @@
## main #689 +/- ##
=======================================
Coverage 81.32% 81.32%
=======================================
Files 49 49
Lines 6467 6467
Branches 1526 1526
=======================================
Hits 5259 5259
- Misses 1016 1017 +1
+ Partials 192 191 -1
📣 Codecov can now indicate which changes are the most critical in Pull Requests. Learn more |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #688 by upgrading the Jinja2 dependency to minimum of major version 3, which does not have the issue with it's markupsafe dependency being incorrect. In order to do this, update the uses of
@jinja2.contextfunctionto use the non-deprecated@jinja2.pass_contextname instead, as this name will be removed in Jinja2 versions>=3.1.0.