Skip to content

Bound number of workers by number of datasets #157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 23, 2024

Conversation

lostella
Copy link
Contributor

Issue #, if available: Fixes #154

Description of changes: Prior to the fix, some workers have no dataset to consume if dataloader_num_workers > len(training_data_paths).

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@lostella lostella requested a review from abdulfatir July 23, 2024 08:15
@lostella lostella added the bugfix Contains a bug fix label Jul 23, 2024
@lostella lostella merged commit 050d600 into amazon-science:main Jul 23, 2024
2 checks passed
@lostella lostella deleted the bound-num-workers branch July 23, 2024 08:37
liu-jc pushed a commit to liu-jc/chronos-forecasting that referenced this pull request Dec 27, 2024
*Issue #, if available:* Fixes amazon-science#154

*Description of changes:* Prior to the fix, some workers have no dataset
to consume if `dataloader_num_workers > len(training_data_paths)`.


By submitting this pull request, I confirm that you can use, modify,
copy, and redistribute this contribution, under the terms of your
choice.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Contains a bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] ValueError when we use only one dataset
2 participants