Skip to content

Ve2 aie_coredump changes #822

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

Ve2 aie_coredump changes #822

wants to merge 3 commits into from

Conversation

@HimanshuChoudhary-Xilinx
Copy link

@HimanshuChoudhary-Xilinx HimanshuChoudhary-Xilinx commented Oct 24, 2025 •
edited
Loading

PR to support aie_coredump for ve2 platform
spec - https://amd.atlassian.net/wiki/spaces/AIE/pages/1098471914/AIE+Coredump

  1. this api return needed size if buffer size is lesser then needed size
  2. we split ve2_partition_read into multiple call for mem and core tile as 0x0 point to memory address

@AMDGithubSCIMAdmin
Copy link

Can one of the admins verify this patch?

@chvamshi-xilinx
Copy link
Contributor

ok to test

chvamshi-xilinx
chvamshi-xilinx requested changes Oct 24, 2025
View reviewed changes
Copy link
Contributor

@chvamshi-xilinx chvamshi-xilinx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as discussed offline, Please restructure some code. Will review again after that.
BTW, Once Rahul's PR is merged, you can update XRT commit id also.

@chvamshi-xilinx
Copy link
Contributor

ok to test

Himanshu Choudhary added 3 commits October 25, 2025 14:23
@chvamshi-xilinx
aie_coredump changes
0c51e8a 
Signed-off-by: Himanshu Choudhary <[email protected]>
@chvamshi-xilinx
restruct
bd60085 
Signed-off-by: Himanshu Choudhary <[email protected]>
@chvamshi-xilinx
restruct
ecbee3d 
Signed-off-by: Himanshu Choudhary <[email protected]>
saifuddin-xilinx added a commit to saifuddin-xilinx/xdna-driver that referenced this pull request Oct 28, 2025
@saifuddin-xilinx
Ve2 aie_coredump changes from PR amd#822
59b70fe 
Signed-off-by: Saifuddin Kaijar <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@chvamshi-xilinx chvamshi-xilinx chvamshi-xilinx requested changes

@maxzhen maxzhen maxzhen approved these changes

@NishadSaraf NishadSaraf Awaiting requested review from NishadSaraf

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@HimanshuChoudhary-Xilinx @AMDGithubSCIMAdmin @chvamshi-xilinx @maxzhen