migrate to electron 12

[amilajack]

Upgrading to new versions of electron is critical for extracting new APIs from recent chromium versions. @sam016 investigated this (see #136 (comment)) and ran into possible config issues related to electron 12. Needs further investigation.

[sam016]

Since Electron 12, contextIsolation is enabled by default.

From Electron 12, it will be enabled by default. For lower versions it is an option in the webPreferences option when constructing new BrowserWindow's.

Ref: https://www.electronjs.org/docs/tutorial/context-isolation#how-do-i-enable-it

For Electron 12+, we would have to explicitly disable it.
In nightmare config, it would look like following:

const config = {
  // eslint-disable-next-line global-require
  electronPath: require("electron"),
  webPreferences: {
    contextIsolation: false,
  },
};

Let's have the latest electron in the repo. 🥂

[amilajack]

Awesome. Would you be interested in creating a PR with the fix?

[sam016]

Yes sure. thanks for the chance.