Update to use --json-version=2

[nwoltman]

The new JSON format is much more consistent and has fewer oddities than the old format.

[amilajack]

The CI test is failing because of this one: https://travis-ci.org/amilajack/eslint-plugin-flowtype-errors/jobs/346625539#L502

[nwoltman]

Whoops, must have hit backspace without realizing. Fixed now.

[amilajack]

Published this as eslint-plugin-flowtype-errors@next again. Would like some testing before bumping the minor semver

[amilajack]

Getting the following error:

messageMarkup.map is not a function
TypeError: messageMarkup.map is not a function
    at /project/node_modules/eslint-plugin-flowtype-errors/dist/collect.js:180:33
    at Array.map (<anonymous>)
    at collect (/project/node_modules/eslint-plugin-flowtype-errors/dist/collect.js:173:28)
    at Program (/project/node_modules/eslint-plugin-flowtype-errors/dist/index.js:83:46)
    at listeners.(anonymous function).forEach.listener (/project/node_modules/eslint/lib/util/safe-emitter.js:47:58)
    at Array.forEach (<anonymous>)
    at Object.emit (/project/node_modules/eslint/lib/util/safe-emitter.js:47:38)
    at NodeEventGenerator.applySelector (/project/node_modules/eslint/lib/util/node-event-generator.js:251:26)
    at NodeEventGenerator.applySelectors (/project/node_modules/eslint/lib/util/node-event-generator.js:280:22)
    at NodeEventGenerator.enterNode (/project/node_modules/eslint/lib/util/node-event-generator.js:294:14)
error Command failed with exit code 1.
info Visit https://yarnpkg.com/en/docs/cli/run for documentation about this command.

[amilajack]

There are some cases where the messageMarkup is actually an object. It fails when it is equal to:

{ kind: 'UnorderedList',
  message: 
   [ { kind: 'Text', text: 'Cannot get ' },
     { kind: 'Code', text: 'exportOptions.tables' },
     { kind: 'Text', text: ' because:' } ],
  items: 
   [ [ [Object], [Object], [Object], [Object], [Object] ],
     [ [Object], [Object], [Object], [Object], [Object] ] ] }

[nwoltman]

@amilajack Could you post some code that will produce this error?

[amilajack]

// @flow
type foo = {} & ({ a: Array<string> } | { b: string });

class bar {
 foo(a: foo) {
    if ('b' in a) {
      a.foo.map(e => e(e))
    }
  }
}

[jdmota]

facebook/flow@28c8a3e

@nwoltman I think you just missed this

type Message = MessageInline | MessageBlock;

type MessageBlock = MessageUnorderedList;

type MessageUnorderedList = {
  kind: 'UnorderedList',
  message: MessageInline,
  items: Array<Message>,
};

That explains why the message might be an object.

[jdmota]

I think it's easier if you just copy the types from facebook's commit message, to our code. That way, we won't forget anything.

[nwoltman]

@jdmota Thanks for pointing out that commit! I'll get to it tomorrow.