Skip to content

Add support for and apply auto code formatting #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 8, 2021
Merged

Conversation

thegostep
Copy link
Contributor

No description provided.

@thegostep thegostep mentioned this pull request Dec 23, 2020
12 tasks
view
returns (uint256)
{
function totalSupply() public view returns (uint256) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I prefer the existing format for function modifiers. Don't consider it a blocker though.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think that is configurable unfortunately, I would recommend sticking to what is supported under prettier-solidity: https://github.com/prettier-solidity/prettier-plugin-solidity

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SGTM

@ahnaguib ahnaguib changed the title add formatting Add support for and apply auto code formatting Jan 6, 2021
#Buidler files
cache
artifacts
.openzeppelin
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

newline at EOF? (and other files)

@thegostep thegostep merged commit 3442040 into master Jan 8, 2021
@thegostep thegostep deleted the formatting branch January 8, 2021 01:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants