Skip to content

Elastic token standard: Interface update #180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 11, 2021
Merged

Elastic token standard: Interface update #180

merged 1 commit into from
Jan 11, 2021

Conversation

aalavandhan
Copy link
Member

@aalavandhan aalavandhan commented Jan 8, 2021 •
edited
Loading

Adding public view 2 methods to the AMPL ERC-20, similar to AAVE's aToken to expose the internal user balance and total supply.

  • scaledBalanceOf : internal gon balance
  • scaledTotalSupply : total number of gons

Fixes: #179

brandoniles
brandoniles approved these changes Jan 8, 2021
View reviewed changes
Copy link
Member

@brandoniles brandoniles left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thegostep
thegostep approved these changes Jan 9, 2021
View reviewed changes
Copy link
Contributor

@thegostep thegostep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - I am still partial to exposing gons with an ERC20 interface through a separate address for improved composability, but that admittedly makes things a bit more funky

@aalavandhan
Copy link
Member Author

@thegostep yea we've talked about that. I dont see why we can't do that independent of this

@thegostep
Copy link
Contributor

@thegostep yea we've talked about that. I dont see why we can't do that independent of this

makes sense - though it does require a token upgrade to deploy

@aalavandhan aalavandhan merged commit aa041bc into master Jan 11, 2021
@aalavandhan aalavandhan deleted the interface-update branch January 21, 2021 02:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@brandoniles brandoniles brandoniles approved these changes

@ahnaguib ahnaguib ahnaguib approved these changes

@thegostep thegostep thegostep approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Expose scaled balances similar to aTokens
4 participants
@aalavandhan @thegostep @brandoniles @ahnaguib