Updated function access modifiers #186
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ahnaguib
approved these changes
Jan 12, 2021
brandoniles
approved these changes
Jan 12, 2021
| @@ -249,7 +249,7 @@ contract UFragmentsPolicy is Ownable { | |||
| * @return Computes the total supply adjustment in response to the exchange rate | |||
| * and the targetRate. | |||
| */ | |||
| function computeSupplyDelta(uint256 rate, uint256 targetRate) private view returns (int256) { | |||
| function computeSupplyDelta(uint256 rate, uint256 targetRate) internal view returns (int256) { | |||
There was a problem hiding this comment.
Confusingly, I think private -> internal has both a gas change (jump w/ no memory clear) and a functional change (visibility within derived contracts). Just pointing out the change to visibility, but I think that's ok.
https://docs.soliditylang.org/en/v0.8.0/control-structures.html?highlight=internal#internal-function-calls
https://docs.soliditylang.org/en/v0.8.0/contracts.html?highlight=private#visibility-and-getters
There was a problem hiding this comment.
Noted. Yea. That's weird
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #185 #183