fix: add support for Decimal property values#187
Merged
crleona merged 2 commits intoamplitude:mainfrom Jul 8, 2024
doctorcooper:fix-add-nsdecimal-support
Merged
fix: add support for Decimal property values#187crleona merged 2 commits intoamplitude:mainfrom doctorcooper:fix-add-nsdecimal-support
crleona merged 2 commits intoamplitude:mainfrom
doctorcooper:fix-add-nsdecimal-support
Conversation
Collaborator
|
Hi @doctorcooper, could you please fix the lint warnings? Otherwise, I have been working on a more comprehensive fix for Encodable support that will be ready soon. |
Contributor
Author
|
Hello @crleona ! Fixed lint warnings. Thanks! |
Collaborator
|
Thanks @doctorcooper! |
Collaborator
|
@doctorcooper, FYI: #192 |
|
🎉 This PR is included in version 1.7.0 🎉 The release is available on:
Your semantic-release bot 📦🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This simple adding fixes converting dictionary which contains decimal value and passing through API.
We've faced with issue that decimal values were ignored on Amplitude console on this framework, but legacy framework works well.
Checklist