-
Notifications
You must be signed in to change notification settings - Fork 42
fix: deprecate defaultTracking and add autocapture #204
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
PouriaAmini
merged 9 commits into
amplitude:feature-autocapture
from
PouriaAmini:deprecate-default-tracking
Aug 2, 2024
Merged
Changes from 4 commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
4534a2d
fix: deprecate defaultTracking and add autocapture
PouriaAmini dd3f384
fix: fix schema for the new test
PouriaAmini d86caa8
fix: fix typo
PouriaAmini 576a139
fix: fix typo
PouriaAmini d1d2288
fix: support optionset for autocapture options
PouriaAmini 1884520
fix: fix autocaptureoptions test
PouriaAmini 167ac4d
fix: fix failing test
PouriaAmini f68eb0c
fix: simplified the logic to deprecate defaultTracking
PouriaAmini cb49254
style: make autocapture options for objc as properties
PouriaAmini File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| import Foundation | ||
|
|
||
| public class AutocaptureOptions { | ||
| public var sessions: Bool = true | ||
| public var appLifecycles: Bool | ||
| public var screenViews: Bool | ||
| public var elementInteractions: Bool | ||
|
PouriaAmini marked this conversation as resolved.
Outdated
|
||
|
|
||
| public init( | ||
| sessions: Bool = true, | ||
| appLifecycles: Bool = false, | ||
| screenViews: Bool = false, | ||
| elementInteractions: Bool = false | ||
| ) { | ||
| self.sessions = sessions | ||
| self.appLifecycles = appLifecycles | ||
| self.screenViews = screenViews | ||
| self.elementInteractions = elementInteractions | ||
| } | ||
| } | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.