Conversation
5f1969f to
7d24517
Compare
2e267fe to
1c63fca
Compare
dff57f5 to
03d561d
Compare
754d0e9 to
91d5264
Compare
91d5264 to
28c2b91
Compare
ecca735 to
e314f41
Compare
e314f41 to
af81a9a
Compare
|
📝 Documentation updates detected! New suggestion: Document enableDiagnostics configuration option for iOS Swift SDK |
|
bugbot run |
crleona
left a comment
There was a problem hiding this comment.
Would it make sense to centralize (at least some of) the autocapture logic? it looks like you're already halfway there with the changes to report which autocapture options are enabled to diagnostics.
19ee8e6 to
4a85018
Compare
4a85018 to
051ed7d
Compare
b53b766 to
bbcbc7d
Compare
@crleona sounds good. It’s a bit too scattered right now. I will submit another PR to handle this. Currently, the UT success rate has improved a lot. There are still some issues, but it’s back within an acceptable range. Next, adding the feature to pass in the identity during init can further boost the success rate. |
|
📝 Documentation updates detected! Updated existing suggestion: Document enableDiagnostics configuration option for iOS Swift SDK |
nice! |
Summary
Checklist
Note
Integrates diagnostics across the SDK, adds a NoUIKit variant, updates core dependency, and refreshes autocapture/remote-config, tests/CI, and build scripts.
DiagnosticsClientviaConfigurationandAmplitudeContext; addenableDiagnosticsdefault and remote client initialization.PersistentStorageResponseHandler.AutocaptureOptions.stringRepresentation()and track enabled autocapture viaupdateEnabledAutocapturefrom Remote Config (sessions, app lifecycles, screen/interactions, network).Amplitude-Swift-NoUIKittarget andAmplitude-Swift-Package-DisableUIKitscheme; enforce no UIKit linkage with shell script.AmplitudeCorevsAmplitudeCoreNoUIKitthroughout sources.build_framework.shto build by scheme (incl. NoUIKit).AmplitudeCore-Swiftto1.3.1(SPM and Xcode project).macos-15, Xcode16.4, newer OS/device matrices; ObjC example runs on iOS 18.5.allowlist.FakeDiagnosticsClient; overhaul Remote Config test harness; adjust expectations/timings and sequencing; numerous test updates to pass new interfaces.Written by Cursor Bugbot for commit bccdc33. Configure here.