feat(analytics-browser): add dead + rage clicks to analytics-browser #1162
Conversation
…m:amplitude/Amplitude-TypeScript into AMP-125613/add-dead-clicks-to-element-interactions
… AMP-125613/add-dead-clicks-to-element-interactions
… AMP-125613/add-dead-clicks-to-element-interactions
![cursor[bot]](https://avatars.githubusercontent.com/in/1210556?s=60&v=4){kind=small}
There was a problem hiding this comment.
Bug: Debug Statement Left In Code
A debug console.log('!!!options', options); statement was accidentally left in the code and should be removed to prevent console output pollution.
packages/plugin-autocapture-browser/src/frustration-plugin.ts#L36-L37
Bug: Test Name Mismatch
The test name for isFrustrationInteractionsEnabled with an undefined parameter ("should return true with undefined parameter") contradicts its assertion (toBe(false)). The test name should be updated to "should return false with undefined parameter" to accurately reflect the expected behavior.
packages/analytics-browser/test/default-tracking.test.ts#L21-L24
Comment bugbot run to trigger another review on this PR
Was this report helpful? Give feedback by reacting with 👍 or 👎
|
📝 Documentation updates detected! New suggestion: Document frustrationInteractions autocapture option for Browser SDK |
daniel-graham-amplitude
changed the base branch from
main
to
frustration-analytics
|
✅ No documentation updates required. |
| @@ -160,6 +161,11 @@ export interface AutocaptureOptions { | |||
| * @defaultValue `false` | |||
| */ | |||
| elementInteractions?: boolean | ElementInteractionsOptions; | |||
| /** | |||
| * Enables/disables frustration interactions tracking. | |||
| * @defaultValue `false` | |||
There was a problem hiding this comment.
based on the code it looks like the default value is true?
There was a problem hiding this comment.
It should be "false" by default. Just like elementInteractions. Is it not?
There was a problem hiding this comment.
I implemented "isFrustrationInteractionsEnabled" the same as "isElementInteractionsEnabled" so it should be the same
daniel-graham-amplitude
force-pushed
the
frustration-analytics
branch
from
8aa11ab to
27cbf45
Compare
daniel-graham-amplitude
changed the base branch from
frustration-analytics
to
frustration-analytics-1
daniel-graham-amplitude
force-pushed
the
AMP-125613/config-prerelease
branch
from
06b3905 to
87970f9
Compare
daniel-graham-amplitude
changed the base branch from
frustration-analytics-1
to
frustration-analytics
…e-TypeScript into AMP-125613/config-prerelease
Summary
Add public API for capturing dead clicks and rage clicks via a new configuration called "autocapture.frustrationInteractions".
Checklist