Skip to content

fix: reduce redundant array creation in getHierarchy #1194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: main
Choose a base branch
from
+27 −11
Draft

fix: reduce redundant array creation in getHierarchy #1194

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
7d63b15
fix: reduce redundant array creation in getHierarchy
daniel-graham-amplitude Jul 4, 2025
ff32360
fix: optimize attributes check
daniel-graham-amplitude Jul 4, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
38 changes: 27 additions & 11 deletions packages/plugin-autocapture-browser/src/hierarchy.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,15 +45,26 @@ export function getElementProperties(element: Element | null): HierarchyNode | n
tag: tagName,
};

const siblings = Array.from(element.parentElement?.children ?? []);
if (siblings.length) {
properties.index = siblings.indexOf(element);
properties.indexOfType = siblings.filter((el) => el.tagName === element.tagName).indexOf(element);
// Get index of element in parent's children and index of type of element in parent's children
let indexOfType = 0,
indexOfElement = 0;
const siblings = element.parentElement?.children ?? [];
while (indexOfElement < siblings.length) {
const el = siblings[indexOfElement];
if (el === element) {
properties.index = indexOfElement;
properties.indexOfType = indexOfType;
break;
}
indexOfElement++;
if (el.tagName === element.tagName) {
indexOfType++;
}
}

const prevSiblingTag = element.previousElementSibling?.tagName?.toLowerCase();
if (prevSiblingTag) {
properties.prevSib = String(prevSiblingTag);
const previousElement = element.previousElementSibling;
if (previousElement) {
properties.prevSib = String(previousElement.tagName).toLowerCase();
}

const id = element.getAttribute('id');
Expand All @@ -67,24 +78,29 @@ export function getElementProperties(element: Element | null): HierarchyNode | n
}

const attributes: Record<string, string> = {};
const attributesArray = Array.from(element.attributes);
const filteredAttributes = attributesArray.filter((attr) => !BLOCKED_ATTRIBUTES.includes(attr.name));
const isSensitiveElement = !isNonSensitiveElement(element);

// if input is hidden or password or for SVGs, skip attribute collection entirely
let hasAttributes = false;
if (!HIGHLY_SENSITIVE_INPUT_TYPES.includes(String(element.getAttribute('type'))) && !SVG_TAGS.includes(tagName)) {
for (const attr of filteredAttributes) {
for (let i = 0; i < element.attributes.length; i++) {
const attr = element.attributes[i];
if (BLOCKED_ATTRIBUTES.includes(attr.name)) {
continue;
}

// If sensitive element, only allow certain attributes
if (isSensitiveElement && !SENSITIVE_ELEMENT_ATTRIBUTE_ALLOWLIST.includes(attr.name)) {
continue;
}

// Finally cast attribute value to string and limit attribute value length
attributes[attr.name] = String(attr.value).substring(0, MAX_ATTRIBUTE_LENGTH);
hasAttributes = true;
}
}

if (Object.keys(attributes).length) {
if (hasAttributes) {
properties.attrs = attributes;
}

Expand Down
Loading