Skip to content

Add additional check if password hash is empty in auth process #1068

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Add additional check if password hash is empty in auth process #1068

wants to merge 1 commit into from

Conversation

rafczow
Copy link

@rafczow rafczow commented Aug 4, 2021

Fixes #1067

Additional details about this PR

Same issue was found in core magento module and is described in this issue:
magento/magento2#19060
and solved here:
https://github.com/magento/magento2/pull/19066/files

My PR is copy of that solution

@zichicc zichicc self-requested a review August 4, 2021 08:32
@jaybeckr
Copy link
Contributor

jaybeckr commented Aug 4, 2021

Thanks for the fix! We have cherry picked the commit to be included in the next release.

@christianzichichi - please close this PR, ref internal ticket ASD-757

@rafczow rafczow closed this Aug 5, 2021
@rafczow
Copy link
Author

rafczow commented Aug 5, 2021

@jaybeckr ive realized there is also translation function missing in that file, it is:
$this->messageManager->addErrorMessage('The password supplied was incorrect');
and should be:
$this->messageManager->addErrorMessage(__('The password supplied was incorrect'));

Should i create separate PR or can you add it internally? :)

@jaybeckr
Copy link
Contributor

jaybeckr commented Aug 5, 2021

@rafczow - we have an internal ticket to review strings and get translations all updated, I will add the translation wrapper on this string which you can use to alter the messaging (and translate, of course) if desired. Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Login with existing account throws error if password hash is empty
3 participants