-
Notifications
You must be signed in to change notification settings - Fork 1.8k
projects: apardpfwd: Add example project for the apardpfwd #2832
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
|
You need to add an entry for the project documentation in this directory: https://github.com/analogdevicesinc/no-OS/tree/main/doc/sphinx/source/projects/eval |
|
V2:
|
amiclaus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
some comments on my side:
- please sign the cla
- the documentation should go in a separate commit (see example #2787)
|
|
||
| ret = socket_init(&server_socket, &tcp_ip); | ||
| if (ret) | ||
| return ret; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
this leaks the uart_desc and lwip_desc.
|
|
||
| ret = socket_bind(server_socket, 10000); | ||
| if (ret) | ||
| return ret; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto.
|
|
||
| ret = socket_listen(server_socket, MAX_BACKLOG); | ||
| if (ret) | ||
| return ret; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto.
| while (1) { | ||
| ret = socket_accept(server_socket, &client_socket); | ||
| if (ret && ret != -EAGAIN) | ||
| return ret; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto.
| int ret; | ||
| struct no_os_gpio_desc *adin1110_spi_cfg0_desc; | ||
|
|
||
| no_os_gpio_get(&adin1110_spi_cfg0_desc, &adin1110_spi_cfg_0); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
void type function? check all occurences throughout the code.
| return 0; | ||
| } | ||
|
|
||
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
too many trailing blank lines.
|
|
||
| ifeq ($(if $(findstring freertos, $(LIBRARIES)), 1),) | ||
| SRCS += $(PLATFORM_DRIVERS)/maxim_delay.c | ||
| endif No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
missing new line at eof
| adin1110_remove(adin1110); | ||
|
|
||
| return 0; | ||
| } No newline at end of file |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
new line at eof
| #include "adin1110.h" | ||
|
|
||
| /***************************************************************************//** | ||
| * @brief Configure the output port of the AD-APARDPFDW-SL then ping the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fdw or fwd?
| #include "network_interface.h" | ||
|
|
||
| /***************************************************************************//** | ||
| * @brief Configure the output port of the AD-APARDPFDW-SL then open a TCP socket |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ditto.
|
V3:
|
amiclaus
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the documentation is not properly splitted and there are build issues that need addressing.
Added example project for the AD-APARDPFWD-SL add-on board. Signed-off-by: Aron Kis <[email protected]>
Added the README.rst for the AD-APARDPFWD-SL add-on board. Signed-off-by: Aron Kis <[email protected]>
|
V4:
|
Added example project for the AD-APARDPFWD-SL add-on board.
Pull Request Description
Please replace this with a detailed description and motivation of the changes.
You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR.
If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.
PR Type
PR Checklist