Skip to content

Conversation

@aronkis
Copy link
Collaborator

@aronkis aronkis commented Dec 16, 2025

Added example project for the AD-APARDPFWD-SL add-on board.

Pull Request Description

Please replace this with a detailed description and motivation of the changes.
You can tick the checkboxes below with an 'x' between square brackets or just check them after publishing the PR.
If this PR contains a breaking change, list dependent PRs and try to push all related PRs at the same time.

PR Type

  • Bug fix (change that fixes an issue)
  • New feature (change that adds new functionality)
  • Breaking change (has dependencies in other repos or will cause CI to fail)

PR Checklist

  • I have followed the Coding style guidelines
  • I have complied with the Submission Checklist
  • I have performed a self-review of the changes
  • I have commented my code, at least hard-to-understand parts
  • I have build all projects affected by the changes in this PR
  • I have tested in hardware affected projects, at the relevant boards
  • I have signed off all commits from this PR
  • I have updated the documentation (wiki pages, ReadMe etc), if applies

@CLAassistant
Copy link

CLAassistant commented Dec 16, 2025

CLA assistant check
All committers have signed the CLA.

@CiprianRegus
Copy link
Contributor

You need to add an entry for the project documentation in this directory: https://github.com/analogdevicesinc/no-OS/tree/main/doc/sphinx/source/projects/eval

@aronkis
Copy link
Collaborator Author

aronkis commented Dec 16, 2025

V2:

  • Added the project documentation to doc/sphinx/source/projects/eval

Copy link
Contributor

@amiclaus amiclaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

some comments on my side:

  • please sign the cla
  • the documentation should go in a separate commit (see example #2787)


ret = socket_init(&server_socket, &tcp_ip);
if (ret)
return ret;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

this leaks the uart_desc and lwip_desc.


ret = socket_bind(server_socket, 10000);
if (ret)
return ret;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.


ret = socket_listen(server_socket, MAX_BACKLOG);
if (ret)
return ret;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.

while (1) {
ret = socket_accept(server_socket, &client_socket);
if (ret && ret != -EAGAIN)
return ret;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.

int ret;
struct no_os_gpio_desc *adin1110_spi_cfg0_desc;

no_os_gpio_get(&adin1110_spi_cfg0_desc, &adin1110_spi_cfg_0);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

void type function? check all occurences throughout the code.

return 0;
}


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

too many trailing blank lines.


ifeq ($(if $(findstring freertos, $(LIBRARIES)), 1),)
SRCS += $(PLATFORM_DRIVERS)/maxim_delay.c
endif No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing new line at eof

adin1110_remove(adin1110);

return 0;
} No newline at end of file
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

new line at eof

#include "adin1110.h"

/***************************************************************************//**
* @brief Configure the output port of the AD-APARDPFDW-SL then ping the
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fdw or fwd?

#include "network_interface.h"

/***************************************************************************//**
* @brief Configure the output port of the AD-APARDPFDW-SL then open a TCP socket
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto.

@aronkis
Copy link
Collaborator Author

aronkis commented Dec 18, 2025

V3:

  • Fixed all code review comments:
    • Added proper error handling and resource cleanup in all error paths
    • Fixed function return types (spi_cfg_0 and port2_cfg)
    • Fixed typos in comments (APARDPFDW → APARDPFWD)
    • Added newlines at end of files
    • Removed trailing blank lines
  • Split documentation into separate commit as requested

Copy link
Contributor

@amiclaus amiclaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

the documentation is not properly splitted and there are build issues that need addressing.

Added example project for the AD-APARDPFWD-SL add-on board.

Signed-off-by: Aron Kis <[email protected]>
Added the README.rst for the AD-APARDPFWD-SL add-on board.

Signed-off-by: Aron Kis <[email protected]>
@aronkis
Copy link
Collaborator Author

aronkis commented Dec 19, 2025

V4:

  • Documentation related modifications now have their own commit.
  • Build issues fixed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants