Add fixed positioning, and the ability to set and get a component size #332

kusti8 · 2018-04-03T21:43:41Z

This fixes #306 and allows me to get yoga working. So far, I've added this and the libui-node bindings as well as yoga to proton-native and it works very well.

I haven;t done any sort of work with GUI libraries really, so feel free to comment on my style. This shouldn't interfere with anything else, since all it does is add a new component. I also did this from the alpha3.5 tag because that is the latest that libui-node supported at the time. It is currently being worked on to work on the latest version.

Gustav

simplexidev · 2018-04-04T17:08:58Z

ui.h

@@ -97,6 +97,8 @@ _UI_EXTERN void uiControlHide(uiControl *);
 _UI_EXTERN int uiControlEnabled(uiControl *);
 _UI_EXTERN void uiControlEnable(uiControl *);
 _UI_EXTERN void uiControlDisable(uiControl *);
+_UI_EXTERN void uiSize(uiControl *control, int *width, int *height);
+_UI_EXTERN void uiSetSize(uiControl *control, int width, int height);


For consistency, should these be names uiControlSize and uiControlSetSize, respectively?

andlabs

I do not agree with making the size of a control a property of the control itself. Sizes should be controlled directly by uiFixed, just as positions are; this is important as it's how all the other containers work anyway. It will also remove the need for the pointless sizing signal logic in the Unix code.

andlabs · 2018-04-04T17:21:11Z

darwin/fixed.m

+// 15 august 2015
+#import "uipriv_darwin.h"
+
+// TODO hiding all stretchy controls still hugs trailing edge


Does this TODO have anything to do with this file?

No. I copied box.m and then modified that since I was unfamiliar with the layout and I forgot to take that out.

andlabs · 2018-04-04T17:21:31Z

.gitignore

@@ -0,0 +1,2 @@
+build


Please remove this file.

andlabs · 2018-04-04T17:21:55Z

darwin/fixed.m

+
+// TODO hiding all stretchy controls still hugs trailing edge
+
+@interface fixedChild : NSObject


Use the name uiprivFixedChild.

andlabs · 2018-04-04T17:22:16Z

darwin/fixed.m

+- (NSView *)view;
+@end
+
+@interface fixedView : NSView {


Use the name uiprivFixedView.

andlabs · 2018-04-04T17:22:48Z

darwin/fixed.m

+	NSMutableArray *children;
+}
+- (id)initFixed:(uiFixed *)bb;
+- (bool)isFlipped;


No need to redeclare isFlipped.

andlabs · 2018-04-04T17:23:54Z

darwin/fixed.m

+- (id)initFixed:(uiFixed *)bb
+{
+	self = [super initWithFrame:NSZeroRect];
+	self.autoresizingMask = NSViewWidthSizable | NSViewHeightSizable;


Always use Objective-C method syntax, even for superclass property getters and setters.

Put this line in the if block.

libui uses Auto Layout; uiprivFixedView should be controllable with Auto Layout, but its contents don't necessarily have to be. I have to figure out how this would work.

I don't think the autoresizingMask is strictly necessary, I think I just added that when trying to debug why the components weren't being sized correctly.

andlabs · 2018-04-04T17:25:14Z

darwin/fixed.m

+	self = [super initWithFrame:NSZeroRect];
+	self.autoresizingMask = NSViewWidthSizable | NSViewHeightSizable;
+	if (self != nil) {
+		// the weird names vert and bb are to shut the compiler up about shadowing because implicit this/self is stupid


No need to copy this comment over from the other files.

andlabs · 2018-04-04T17:28:05Z

darwin/main.m

@@ -10,6 +10,41 @@
 static BOOL (^isRunning)(void);
 static BOOL stepsIsRunning;

+@interface sizeWrapper : NSView {


Why is any of this necessary? You also are not properly initializing or uninitializing instances of these objects.

This was weird to me also. When I used uiDarwinControlHandle and cast it to a NSView*, it complained about fixed not being a property. If I enclosed it in an interface that subclassed NSView, then it worked fine.

andlabs · 2018-04-04T17:28:20Z

darwin/main.m

+{
+	CGSize s = CGSizeMake(width, height);
+	[[[sizeWrapper alloc] addControl:control] setS:s];
+}


Please use newlines at the end of files.

andlabs

More review comments.

andlabs · 2018-04-04T17:30:42Z

unix/fixed.c

+	uiUnixControl c;
+	GtkWidget *widget;
+	GtkContainer *container;
+	GtkFixed *fixed;


Don't use GtkFixed; it does not properly theme with CSS. GtkLayout would be better, but the ideal solution would be to have a custom GtkContainer subclass that does the barest minimum possible. Look at the version of package ui that immediately predated libui for details. (I can do this later too.)

I'll look at that.

Ok I finally got more time to look at this. I assume you're talking about this: https://github.com/andlabs/ui/blob/de9d72299fb89a8b6cdc8963cd6b6ae708a81e80/container_unix.c
So you're overriding GtkContainer, but where do you actually set children size and location?

@andlabs How exactly would this work? I haven't done that much work with GTK.

Line 62, which is a Go function. I forget what you call in there for each child control, but you can check the Go code.

andlabs · 2018-04-04T17:31:55Z

windows/winpublic.cpp

@@ -35,6 +35,16 @@ void uiWindowsEnsureMoveWindowDuringResize(HWND hwnd, int x, int y, int width, i
 		logLastError(L"error moving window");
 }

+void uiWindowsResizeWindow(HWND hwnd, int width, int height) {


I'm pretty sure these two are provided in winutil.cpp anyway.

Will review the rest of the code later.

There was uiWindowsEnsureMoveWindowDuringResize, but that moves and resizes the window. I added these functions because when you either move or resize a window, Windows doesn't give accurate values for the other two, so if you want it to move, it'll end up resizing also. Which is why I made these with the SWP_NOSIZE and SWP_NOMOVE flags.

andlabs

Missed a spot

andlabs · 2018-04-04T17:33:42Z

darwin/fixed.m

+	return self;
+}
+
+- (bool)isFlipped


BOOL, not bool.

kusti8 · 2018-04-04T18:51:46Z

I've made most of the changes. As for having uiFixed control the sizing, I agree that it's a good idea, and it seems like it will work with my code so I'll change that.

mischnic · 2018-04-04T18:55:44Z

darwin/fixed.m

@@ -165,7 +162,7 @@ static void uiFixedSyncEnableState(uiDarwinControl *c, int enabled)
 uiDarwinControlDefaultHugsBottom(uiFixed, view)
 uiDarwinControlDefaultChildEdgeHuggingChanged(uiFixed, view)

-static void uiFixedChildVisibilityChanged(uiDarwinControl *c)
+static void uiuiprivFixedChildVisibilityChanged(uiDarwinControl *c)


One "ui" too much

Yeah I pushed so that I could check the changes in my VM. I'll fix that.

andlabs · 2018-04-04T20:54:17Z

Also I need to formalize some of the suggestions I made here into the contribution guidelines. Sorry if I came off as aggressive with any of them; these are just policies specific to libui to keep everything consistent!

kusti8 · 2018-04-04T21:54:51Z

No it's all right. I'm all for keeping code quality and style consistent. I've just never really worked with Objective C and C++ as much.

…

On Wed, Apr 4, 2018, 4:54 PM Pietro Gagliardi ***@***.***> wrote: Also I need to formalize some of the suggestions I made here into the contribution guidelines. Sorry if I came off as aggressive with any of them; these are just policies specific to libui to keep everything consistent! — You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub <#332 (comment)>, or mute the thread <https://github.com/notifications/unsubscribe-auth/AJW73GkGbP9k7060SpymJu4IVhgslmFzks5tlTL_gaJpZM4TF1cl> .

andlabs · 2018-04-04T22:20:50Z

Also for the uipriv naming thing see #308 — we might as well start applying this to new code to make things easier when I move everything proper. utflib-and-attrstr started doing it already.

kusti8 · 2018-04-06T20:49:33Z

Alright sizing should be moved to uiFixed now.

kusti8 · 2018-05-19T17:21:22Z

Ok @andlabs I finally got a chance to implement a custom container, which I've added as fixedContainer.c. I used your old libui code and GtkFixed's source code as example which I merged, and it works well. Let me know what you think.

kusti8 · 2018-05-29T15:42:51Z

@andlabs sorry for bothering you but is there anything else that I need to do? Thanks!

kusti8 · 2018-07-08T07:40:58Z

@andlabs I know you're busy but what's the status on this?

brunolemos · 2018-07-15T14:39:16Z

Hopefully this can get merged so the work on kusti8/proton-native#76 can continue!

andlabs · 2018-08-09T14:31:07Z

I was going to write a big long expalantion of why I didn't want to merge this PR in, but thinking about it now it's been too long and I forgot exactly what I was going to say at the time. Sorry.

Here's the general gist of what my objections were:

the idea of the fixed layout in the first place is one I deliberately wanted to avoid having at all, because of the room for error and the amount of work it would take to make it error-free
I didn't want to include Yoga in libui itself as a fix for uiGrid, partially because the license is not compatible, partially because it would be a massive dependency, partially because GtkGrid, and partially because Auto Layout
I still don't fully understand Auto Layout — it seems like things like responding to when a basic control's intrinsic content size has changed should be something it does for us, and yet many of the bugs in uiBox and uiGrid can be boiled down to "it's not that simple"; at the same time, this PR doesn't seem to watch intrinsic content size changes at all

Of course, these original comments seem invalid now anyway, because I only see the Fixed code in the PR, not the code for any of the support APIs. What happened?

And then again, other UI toolkits have had fixed layouts alongside dynamic layouts for a while and haven't had major problems, so maybe I was just worrying too much. Perhaps a uiFixed is fine, though there's still a few things missing from libui that would allow one to be used "correctly".

I'll consider this again during the development of Alpha 5, as I want to make some major changes to uiControl itself for that (some of which were requested here).

kusti8 · 2018-08-10T00:43:44Z

That's alright.

The original PR never included any yoga or anything like that for the exact purpose to keep libui light weight. I simply added an API for fixed position of objects. That API is used by me in JS which integrates with Yoga at that level, since yoga had a JS wrapper. Whever a change is seen by me, that is sent to yoga to recompute the coordinates and that moves everything.

andlabs · 2018-08-10T04:11:01Z

The ideal thing is there should be one place where you can hook into to spot control size changes. Alpha 5 will include that, since I'll be redoing uiControl entirely. This should probably also automatically mirror on an RTL system, but I have no idea where to start with that.

I'll still review this PR and see if we can put this container in.

SkyzohKey · 2018-11-22T10:31:30Z

Hey @andlabs @kusti8 any progress on this ? :)

langovoi · 2019-01-22T11:10:57Z

Any updates?

andlabs · 2019-01-22T14:46:29Z

The work on Alpha 5 will allow this to be feasible without encouraging the kind of mistakes that cause other toolkits (including this one) to avoid including this. It'll have to wait one more version.

kusti8 added 14 commits March 23, 2018 19:05

Add fixed for unix

4d049e7

Remove example build

6e13520

Merge

eb2cf91

Remove build dir

12b4e09

Fix size to be actual size and add uiSetSize

9420237

Rename size and add natural size also

1e0e131

Small size fixes

8f3d3e9

Add fixed and size to windows

0d52537

Add initial mac fixed

7ed39c3

Finish mac fixed and size setting

c2ab097

Move width and height to ui_unix

8ce458d

Remove vscode

c82d891

Make setting size work by setting frame size also

66095ae

Merge branch 'master' into alpha3.5

c839153

kusti8 mentioned this pull request Apr 3, 2018

Fixed positioning #306

Open

simplexidev reviewed Apr 4, 2018

View reviewed changes

andlabs reviewed Apr 4, 2018

View reviewed changes

darwin/fixed.m Outdated

return self;

}

- (bool)isFlipped

Copy link

Owner

andlabs Apr 4, 2018

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

BOOL, not bool.

kusti8 added 2 commits April 4, 2018 14:52

Rename fixed implementations

84f81c2

Remove resize mask and fix compile errors

452742f

mischnic reviewed Apr 4, 2018

View reviewed changes

kusti8 added 4 commits April 4, 2018 18:16

Move size to uiFixed on mac

fbabdff

Move uiSize on Linux

1def874

Move fixed size for Windows

11710e4

Add initial layout with size because Windows doesn't set size by default

570f7e0

simplexidev mentioned this pull request Apr 17, 2018

Support for uiFixed simplexidev/sdevlibs#5

Closed

mischnic mentioned this pull request May 13, 2018

Add yoga support. Fixes #67 kusti8/proton-native#76

Closed

kusti8 added 5 commits May 19, 2018 12:49

Make custom container

9bbc402

Fix syle on container

5d4f9f7

Merge branch 'master' into alpha3.5

c89fc32

Rename userbug on darwin

cb1fae6

Typo in userbug

3c326ee

Add uiFixedSize back

1ed637a

mischnic mentioned this pull request Sep 28, 2018

Add yoga layout support kusti8/proton-native#67

Closed

3 tasks

andlabs modified the milestones: Unassigned Backlog, Alpha 5, Post-Alpha 5 Dec 31, 2018

mischnic mentioned this pull request Apr 9, 2019

Is it possible to render elements on top of other elements? kusti8/proton-native#209

Closed

cody271 mentioned this pull request Jan 9, 2022

Master issue for merging old PRs libui-ng/libui-ng#8

Open

cody271 mentioned this pull request Jan 16, 2022

uiFixed control libui-ng/libui-ng#33

Open


		// TODO hiding all stretchy controls still hugs trailing edge

		@interface fixedChild : NSObject

Add fixed positioning, and the ability to set and get a component size #332

Are you sure you want to change the base?

Add fixed positioning, and the ability to set and get a component size #332

Uh oh!

Conversation

kusti8 commented Apr 3, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andlabs left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andlabs left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andlabs left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

kusti8 commented Apr 4, 2018

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

andlabs commented Apr 4, 2018

Uh oh!

kusti8 commented Apr 4, 2018 via email

Uh oh!

andlabs commented Apr 4, 2018

Uh oh!

kusti8 commented Apr 6, 2018

Uh oh!

kusti8 commented May 19, 2018

Uh oh!

kusti8 commented May 29, 2018

Uh oh!

kusti8 commented Jul 8, 2018

andlabs left a comment •

edited

Loading

andlabs commented Aug 9, 2018 •

edited

Loading

andlabs commented Aug 10, 2018 •

edited

Loading