Fix #218: Delete old TestRunner module and update README references

[andreasronge]

Summary

• Delete deprecated PtcDemo.TestRunner module file
• Update README.md to reference PtcDemo.JsonTestRunner instead
• Preserve shared test modules in test_runner/ directory (used by both runners)

Verification

All checks pass:

• ✅ mix compile --warnings-as-errors passes
• ✅ All 125 demo tests pass
• ✅ Both JSON and Lisp CLIs work correctly

Fixes #218

🤖 Generated with Claude Code

[github-actions]

PR Review: Fix #218: Delete old TestRunner module and update README references

Summary

This PR completes Phase 3.3 of the test runner refactoring plan by deleting the deprecated PtcDemo.TestRunner module (256 lines) and updating README.md references to point to PtcDemo.JsonTestRunner. A well-scoped cleanup PR that executes exactly what was specified in the issue.

What's Good

• Clean deletion: The deprecated module is completely removed, no partial cleanup
• README updates complete: All 5 references in the README are correctly updated from PtcDemo.TestRunner to PtcDemo.JsonTestRunner
• Shared modules preserved: The test_runner/ directory with shared modules (Base, TestCase, Report) is correctly left intact - these are used by both JsonTestRunner and LispTestRunner
• PR description clearly documents what was changed and verification steps
• Follows the refactoring plan: Matches Phase 3.3 task in demo/docs/test-runner-refactor-plan.md

Issues (Must Fix)

None found.

Suggestions (Optional)

None - this is a minimal, well-scoped cleanup PR.

Security

No concerns - this is a straightforward deletion of deprecated code and documentation update.

Documentation

• ✅ README.md updated with correct module references
• The test-runner-refactor-plan.md remains accurate (still references the Phase 3.3 task with "DELETE" action for test_runner.ex)

Verdict

Approve - The PR correctly implements issue #218. All references to the old PtcDemo.TestRunner module are removed, shared modules are preserved, and the README is updated. The verification steps in the PR description confirm the change is safe (compile passes, all tests pass, both CLIs work).

[andreasronge]

Auto-Triage Summary

Review Analysis

The PR review found 0 issues requiring fixes and 0 suggestions for future improvements.

Verdict

✅ Clean approval - The PR correctly implements issue #218:

• Deprecated PtcDemo.TestRunner module completely deleted (256 lines)
• All 5 README.md references updated to PtcDemo.JsonTestRunner
• Shared modules in test_runner/ directory correctly preserved
• Follows Phase 3.3 of the refactoring plan
• All verification checks pass

Decisions Made

#	Issue	Decision	Reason
-	-	-	No issues or suggestions found in review

Status

• FIX_NOW items: 0
• Issues created: 0
• Items ignored: 0

Next Steps

Added ready-to-merge label. The PR is ready for auto-merge once all required checks pass.