Closed
Conversation
andreasronge
force-pushed
the
test/verify-claude-action
branch
from
98370f6 to
e433f33
Compare
andreasronge
added a commit
that referenced
this pull request
Dec 1, 2025
…x execution (#10) * feat: implement Phase 1 core interpreter with JSON parsing and sandbox execution Implements the foundational Phase 1 of PtcRunner including: - **Parser**: JSON string and map parsing with error handling - **Validator**: DSL schema validation for all Phase 1 operations - **Context**: Variable bindings management - **Operations**: Core data, control flow, collection, comparison, and aggregation operations - Data: literal, load, var - Control: pipe - Collections: filter, map, select - Comparison: eq - Aggregations: sum, count - **Interpreter**: AST evaluation with operation dispatch - **Sandbox**: Isolated BEAM process execution with timeout and resource monitoring All programs execute in isolated processes with configurable timeouts and memory limits, returning execution metrics (duration_ms, memory_bytes). Includes comprehensive test coverage for all operations, error cases, and edge cases. Fixes #7 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * fix: resolve PR review issues for validation and sandbox - Fix validate_list/1: Use Enum.reduce_while instead of Enum.find to properly validate all nested operations (Issue #1) - Fix sandbox memory limits: Pass max_heap option to Process.spawn to enforce memory limits (Issue #2) - Add test for nested validation errors: Verify validation catches unknown operations inside pipe steps (Issue #3) 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * fix: resolve PR review issues for timeout and memory errors - Fix timeout error format to match architecture.md: return {:error, {:timeout, timeout_value}} instead of {:error, :timeout} - Fix memory exceeded error detection: distinguish between memory killed (:killed reason) and timeout kills - Update sandbox.ex:72-76 to handle :killed reason as memory exceeded with {:error, {:memory_exceeded, max_heap * 8}} - Update sandbox.ex:82 to return {:error, {:timeout, timeout}} for explicit timeout kills - Update test case to expect new timeout error format {:timeout, 0} instead of :timeout 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com> * chore: update PM status - PR #10 Phase 1 implementation --------- Co-authored-by: claude[bot] <41898282+claude[bot]@users.noreply.github.com> Co-authored-by: Claude <noreply@anthropic.com>
This was referenced Dec 9, 2025
5 tasks
This was referenced Jan 1, 2026
4 tasks
7 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Test plan
🤖 Generated with Claude Code