CMake 3.19+ compatability with MSVC. #254
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix CMake 3.18 MSVC build issues described here microsoft/Azure-Kinect-Sensor-SDK#1363 following this https://gitlab.kitware.com/cmake/cmake/-/issues/22356 Also removed the empty .lib appended to the linker.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There are currently build issues with newer CMake versions on Windows using MSVC. The /TP flag is not being propagated properly anymore in newer CMake versions (See https://gitlab.kitware.com/cmake/cmake/-/issues/22356), which results in the __cplusplus flag not existing for the atomics.h -> stdatomics.h related compile errors with MSVC.
There is also an issue of an empty .lib being added to the linker with MSVC.
Both should be fixed by this PR.