-
Notifications
You must be signed in to change notification settings - Fork 94
Add isp-setup service #343
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What happens if someone later removes isp files, how can we remove them from /var/nvidia/nvcam?
Do we need to clear the cache files nvidia makes here? (Could you document what those are?)
What can we do to test this functionality?
modules/isp-setup.nix
Outdated
|
||
enable = mkEnableOption "ISP setup"; | ||
|
||
path = mkOption { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This should probably be an option under hardware.jetpack-nixos
instead of something separate.
Could the option just be a list of packages which provide isp files? It'd be empty by default, so I don't see the need for an enable
field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Went ahead with this it's now a list of paths if empty it wont start the service.
Verified what, exactly? |
Per the forums (since there are no docs :/) it seems the nvcam_cache_.bin and serial_no_.bin speed up camera pipeline initialization and only need to be updated when the underlying camera_override isp files have changed. For testing we would need to verify that nvargus or libargus initialize and are able to read the override.isp files at /var/nvidia/nvcam |
8573fda
to
221ab41
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved with a minor description nit
default = [ ]; | ||
description = '' | ||
The list of packages that contain isp files. This | ||
will copy any files in the /nvcam directory to the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
will copy any files in the /nvcam directory to the | |
will copy any files in the /nvcam directory of each package to the |
Description of changes
Creates a service that will copy all files under
nvcam
specified inhardware.nvidia-jetpack.ispPkgs
into the/var/nvidia/nvcam
directory. Whenever this list of pkgs gets updated the/var/nvidia/nvcam
directory will be recreated.Testing
Verified files were copied into /var/nvidia/nvcam on an orin-agx. nvargus was able to read the .isp files and image captured using nvargus pipeline had isp configuration applied.